Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKG-Gen should take the latest stable CKEditor 5 version #155

Closed
pomek opened this issue Jul 3, 2023 · 0 comments · Fixed by #158
Closed

PKG-Gen should take the latest stable CKEditor 5 version #155

pomek opened this issue Jul 3, 2023 · 0 comments · Fixed by #158
Assignees
Labels
squad:devops Issue to be handled by the Devops team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@pomek
Copy link
Member

pomek commented Jul 3, 2023

📝 Provide a description of the improvement

Travis reports the following error:

Webpack bundling...
[
  {
    moduleIdentifier: 'javascript/esm|/home/travis/build/ckeditor/ckeditor5-test-package/node_modules/@ckeditor/ckeditor5-core/src/index.js',
    moduleName: './node_modules/@ckeditor/ckeditor5-core/src/index.js',
    loc: '8:0-45',
    message: "Module not found: Error: Can't resolve './plugin' in '/home/travis/build/ckeditor/ckeditor5-test-package/node_modules/@ckeditor/ckeditor5-core/src'\n" +
      "Did you mean 'plugin.js'?\n" +
      "BREAKING CHANGE: The request './plugin' failed to resolve only because it was resolved as fully specified\n" +
      `(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '*.mjs' file, or a '*.js' file where the package.json contains '"type": "module"').\n` +
      'The extension in the request is mandatory for it to be fully specified.\n' +
      'Add the extension to the request.',

https://app.travis-ci.com/github/ckeditor/ckeditor5-package-generator/jobs/605292891#L778

It can be fixed by applying this change - ckeditor/ckeditor5-dev@efcf009 - in webpack configs.

However, I think the generator should not use alpha releases when preparing a new package. Hence, I propose fetching the @latest version instead of the latest release.

@pomek pomek added squad:devops Issue to be handled by the Devops team. type:improvement This issue reports a possible enhancement of an existing feature. labels Jul 3, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jul 3, 2023
@pomek pomek self-assigned this Jul 4, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Jul 4, 2023
psmyrek added a commit that referenced this issue Jul 5, 2023
Other (generator): When generating a new package, the generator uses the latest stable CKEditor 5 release. Closes #155.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jul 5, 2023
@CKEditorBot CKEditorBot added this to the iteration 65 milestone Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:devops Issue to be handled by the Devops team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants