Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated package contains wrong isToggleable value for a button #97

Closed
mlewand opened this issue Mar 25, 2022 · 0 comments · Fixed by #98
Closed

Generated package contains wrong isToggleable value for a button #97

mlewand opened this issue Mar 25, 2022 · 0 comments · Fixed by #98
Labels
squad:devops Issue to be handled by the Devops team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@mlewand
Copy link

mlewand commented Mar 25, 2022

📝 Provide detailed reproduction steps (if any)

The generated package contains:

view.set( {
	label: t( 'My plugin' ),
	icon: ckeditor5Icon,
	tooltip: true,
	isToggleable: true
} );

isToggleable property is wrong here as the button does not act as a toggle button.

The backstory is that during the reviews recently I've been noticing invalid isToggleable usage for a button and I was wondering where do people take this from 🙂 Turned out it's produced by package generator.

✔️ Expected result

Simply there should be no isToggleable property.

❌ Actual result

There is a isToggleable property.

❓ Possible solution

Let's simply change the template:


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@mlewand mlewand added the type:bug This issue reports a buggy (incorrect) behavior. label Mar 25, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Mar 25, 2022
@pomek pomek added the squad:devops Issue to be handled by the Devops team. label Mar 25, 2022
@pomek pomek closed this as completed in #98 Mar 28, 2022
pomek added a commit that referenced this issue Mar 28, 2022
Fix (generator): Removed the `isToggleable` property from the plugin template. Closes #97.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Mar 28, 2022
@CKEditorBot CKEditorBot added this to the iteration 52 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:devops Issue to be handled by the Devops team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants