Generated package contains wrong isToggleable
value for a button
#97
Labels
squad:devops
Issue to be handled by the Devops team.
type:bug
This issue reports a buggy (incorrect) behavior.
Milestone
📝 Provide detailed reproduction steps (if any)
The generated package contains:
isToggleable
property is wrong here as the button does not act as a toggle button.The backstory is that during the reviews recently I've been noticing invalid
isToggleable
usage for a button and I was wondering where do people take this from 🙂 Turned out it's produced by package generator.✔️ Expected result
Simply there should be no
isToggleable
property.❌ Actual result
There is a
isToggleable
property.❓ Possible solution
Let's simply change the template:
ckeditor5-package-generator/packages/ckeditor5-package-generator/lib/templates/src/myplugin.js
Line 24 in d57cc3e
If you'd like to see this fixed sooner, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: