-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented usage of custom package name in the generated package #128
Conversation
Something went wrong :(
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments.
Other than that, I guess the source files in the templates/
directory should no longer follow the .js
and .ts
extensions. I am fine with using *.txt
, but we lose code highlighting. It does not work, though, as we have a lot of syntax errors right now.
packages/ckeditor5-package-generator/lib/templates/common/ckeditor5-metadata.json
Outdated
Show resolved
Hide resolved
packages/ckeditor5-package-generator/lib/utils/choose-package-manager.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-package-generator/lib/utils/get-package-name.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-package-generator/lib/utils/choose-package-manager.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-package-generator/lib/utils/choose-package-manager.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-package-generator/lib/utils/choose-package-manager.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-package-generator/tests/utils/choose-package-manager.js
Show resolved
Hide resolved
packages/ckeditor5-package-generator/lib/utils/get-package-name.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-package-generator/tests/utils/get-package-name.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-package-generator/lib/utils/get-package-name-formats.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Suggested merge commit message (convention)
Feature: The provided package name will now be used as a default name of a plugin (instead of
MyPlugin
) in the generated package. Closes #54.Feature: Added the
--plugin-name
option that allows specifying the plugin name different from the package name. See #54.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.
Supported scopes
generator
→ https://www.npmjs.com/package/ckeditor5-package-generator*
→ https://www.npmjs.com/package/@ckeditor/ckeditor5-package-*