This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Improved autoparagraphing #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is really good. I needed to work a bit on the comments and, hopefully, I made the process easier to understand. The idea seems great though. I'm not 100% sure it's totally correct but I guess that when a topic is that broad you can never be sure about everything :D |
|
PS. Please make sure I didn't break the comments. |
|
I pushed one commit with one typo corrected (I've seen it and couldn't unseen it). Anyway, your comments make a lot of sense, also thanks for fixing text->item ;). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Autoparagraphing has been improved. "Inline" view elements (both converted to attribute and element) will be now correctly handled and autoparagraphed. Closes ckeditor/ckeditor5#3294. Closes ckeditor/ckeditor5#3296.