Fixed destroy process of a single editor instance working within Context #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psmyrek
approved these changes
Jan 4, 2023
Comment on lines
+148
to
151
| /* istanbul ignore next */ | ||
| if ( this.watchdog ) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
It seems that this condition is no longer necessary. It was added while we were working on double rendering issue. But I leave it just in case.
Comment on lines
+240
to
+250
| setTimeout( () => { | ||
| if ( this.watchdog ) { | ||
| this.watchdog.destroy().then( () => { | ||
| this.watchdog = null; | ||
|
|
||
| resolve(); | ||
| } ); | ||
| } else { | ||
| resolve(); | ||
| } ); | ||
| } else { | ||
| resolve(); | ||
| } | ||
| } | ||
| } ); |
There was a problem hiding this comment.
No idea how to get rid of this setTimeout(), as the <CKEditor /> does not know if <CKEditorContex /> is going to destroy the editor.
Let's keep it as it is.
| // | ||
| // See #354 for more information. | ||
| if ( this._contextWatchdog.state === 'ready' ) { | ||
| return this._contextWatchdog.remove( this._id ); |
There was a problem hiding this comment.
The this._contextWatchdog.remove() returns a promise, as expected.
|
This appears to have fixed #351 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Fixed destroy process of a single editor instance working within Context. Closes #354.