Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new installation methods #482

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

filipsobol
Copy link
Member

@filipsobol filipsobol commented May 31, 2024

Suggested merge commit message (convention)

Feature: Change the implementation to only depend on types from the CKEditor packages and not runtime code to make the integration work with existing and new installation methods.

MINOR BREAKING CHANGE: Add a new required contextWatchdog prop to the <CKEditorContext> component.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 18025ff4-1e3b-4b22-bf62-230cfda8e5d7

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build da15a32b-bada-403f-926b-f8d6ae765cc5: 0.0%
Covered Lines: 70
Relevant Lines: 70

💛 - Coveralls

@Mati365 Mati365 self-requested a review June 3, 2024 08:34
@filipsobol filipsobol merged commit 5f0a7c9 into master Jun 4, 2024
4 checks passed
@filipsobol filipsobol deleted the migrate-master-to-new-installation-methods branch June 4, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants