Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The component will not be updated by React itself #79

Merged
merged 3 commits into from Mar 24, 2019
Merged

The component will not be updated by React itself #79

merged 3 commits into from Mar 24, 2019

Conversation

pomek
Copy link
Member

@pomek pomek commented Mar 21, 2019

Suggested merge commit message (convention)

Fix: The <CKEditor> component will not be updated by React itself. The editor won't freeze if #data property was specified as a static string. Closes #75. Closes #78.

@pomek pomek requested a review from ma2ciek March 21, 2019 16:49
@coveralls
Copy link

coveralls commented Mar 21, 2019

Pull Request Test Coverage Report for Build 169

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 165: 0.0%
Covered Lines: 42
Relevant Lines: 42

💛 - Coveralls

@pomek
Copy link
Member Author

pomek commented Mar 22, 2019

I have an idea of how to update the editor's content when the state has changed. Let me introduce some improvements to this PR.

@pomek
Copy link
Member Author

pomek commented Mar 22, 2019

@ma2ciek, go ahead.

@ma2ciek
Copy link
Contributor

ma2ciek commented Mar 24, 2019

I'm not glad that the editor state changes will go to the shouldComponentUpdate, but since for now it's the only possible way to prevent React from removing CKEditor5 DOM elements on rerendering, I'm merging it. Maybe we'll find a better approach in the future.

@ma2ciek ma2ciek merged commit bdb2ce3 into master Mar 24, 2019
@ma2ciek ma2ciek deleted the t/75b branch March 24, 2019 20:12
@ckeditor ckeditor deleted a comment from pomek Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants