Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #73 from ckeditor/t/72" #82

Merged
merged 2 commits into from Mar 25, 2019
Merged

Revert "Merge pull request #73 from ckeditor/t/72" #82

merged 2 commits into from Mar 25, 2019

Conversation

oskarwrobel
Copy link
Contributor

This reverts commit a31de76, reversing
changes made to 650b9ca.

Suggested merge commit message (convention)

Internal: Removed option for providing React refs to the editor configuration. Closes #72.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

This reverts commit a31de76, reversing
changes made to 650b9ca.
@oskarwrobel oskarwrobel requested a review from pomek March 25, 2019 14:11
@coveralls
Copy link

coveralls commented Mar 25, 2019

Pull Request Test Coverage Report for Build 176

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 170: 0.0%
Covered Lines: 39
Relevant Lines: 39

💛 - Coveralls

@pomek pomek merged commit f085417 into master Mar 25, 2019
@pomek pomek deleted the t/72 branch March 25, 2019 14:27
@ortonomy
Copy link

why would you remove access to refs?

@tkpremier
Copy link

Also curious how to grab editor instance in React if refs are not allowed...please advise via any links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React refs are not correctly recognised by the editor
5 participants