This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
I/6003: Ensure exception marker is flat #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I reverted your changes to the manual test. Other than that, all seems to work fine. Although, I expect to see more problems like this with some other features that have more complicated conversion + post-fixers. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Fix non-flat exception markers. Closes ckeditor/ckeditor5#6003.
The problem was with non-flat range of the marker which happened after upcast conversion.
I've added a "post-fixer" that listens to new markers and fixes non-flat markers. It is rather an edge case and I didn't consider other cases like markers set on
<table>or so which "standard editing mode" does not allow to create.