Merge branch 'master' into i/6114

ckeditor · Feb 28, 2020 · 466bc7d · 466bc7d
2 parents fe2b7a0 + ffe7df6
commit 466bc7d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/src/tablecellproperties/commands/tablecellpropertycommand.js b/src/tablecellproperties/commands/tablecellpropertycommand.js
@@ -114,6 +114,8 @@ export default class TableCellPropertyCommand extends Command {
 }
 
 // Returns all selected table cells.
+// The implementation of this function is incorrect as it may return a single cell twice.
+// See https://github.com/ckeditor/ckeditor5/issues/6358.
 function getSelectedTableCells( model ) {
 	const selection = model.document.selection;
 

diff --git a/src/tableselection.js b/src/tableselection.js
@@ -229,6 +229,7 @@ export default class TableSelection extends Plugin {
 	 * @returns {Iterable.<module:engine/model/element~Element>}
 	 */
 	* getSelectedTableCells() {
+		// TODO: this function should be removed. See https://github.com/ckeditor/ckeditor5/issues/6358
 		if ( !this.hasMultiCellSelection ) {
 			return;
 		}

diff --git a/src/ui/utils.js b/src/ui/utils.js
@@ -81,6 +81,7 @@ export function getBalloonTablePositionData( editor ) {
  * @returns {module:utils/dom/position~Options}
  */
 export function getBalloonCellPositionData( editor ) {
+	// This is a bit naive. See https://github.com/ckeditor/ckeditor5/issues/6357.
 	const modelTableCell = getTableCellAtPosition( editor.model.document.selection.getFirstPosition() );
 	const viewTableCell = editor.editing.mapper.toViewElement( modelTableCell );