Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FF] Active state doesn't work #3336

Closed
oskarwrobel opened this issue Jun 24, 2016 · 7 comments
Closed

[FF] Active state doesn't work #3336

oskarwrobel opened this issue Jun 24, 2016 · 7 comments
Labels
browser:firefox resolution:expired This issue was closed due to lack of feedback. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@oskarwrobel
Copy link
Contributor

On my FF 47.0 in manual test buttons don't change on click.
ff

It is ok when I set active state by browser console:

ff-dev-tools

On Chrome everything is ok:
chrome

Could someone confirm that?

@oleq
Copy link
Member

oleq commented Sep 14, 2016

Related issue #201.

@oleq oleq self-assigned this Sep 14, 2016
@oleq
Copy link
Member

oleq commented Sep 16, 2016

Quick research revealed that the culprit is the evt.preventDefault() on mousedown https://github.com/ckeditor/ckeditor5-ui-default/blob/master/src/button/buttonview.js#L60. This preventDefault prevents the button stealing editable focus.

We must find some other way to prevent focus stealing which does not break CSS states in FF.

Related question on SO http://stackoverflow.com/questions/11464520/aactive-vs-mousedown-event-preventdefault-ed.

@oleq
Copy link
Member

oleq commented Sep 16, 2016

An important note from the spec:

CSS does not define which elements may be in the above states, or how the states are entered and left. Scripting may change whether elements react to user events or not, and different devices and UAs may have different ways of pointing to, or activating elements.

Also see the issue on FF bug tracker.

@oleq
Copy link
Member

oleq commented Sep 16, 2016

Given the complexity of the issue vs. importance, I'm postponing it to the next milestone.

@oleq oleq removed their assignment Sep 16, 2016
@oskarwrobel oskarwrobel changed the title Active state doesn't work on FF 47.0 [FF] Active state doesn't work Nov 8, 2017
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-theme-lark Oct 9, 2019
@Mgsy Mgsy added browser:firefox status:confirmed type:bug This issue reports a buggy (incorrect) behavior. labels Oct 14, 2019
@Reinmar Reinmar added this to the backlog milestone Nov 4, 2019
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added resolution:expired This issue was closed due to lack of feedback. and removed status:stale labels Jan 15, 2024
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:firefox resolution:expired This issue was closed due to lack of feedback. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

7 participants