Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with other browsers #201

Closed
Reinmar opened this Issue Jun 13, 2016 · 8 comments

Comments

Projects
None yet
2 participants
@Reinmar
Copy link
Member

Reinmar commented Jun 13, 2016

So far we're testing in Chrome only. We need to bring compatibility with at least latest versions of Safari, Firefox, Opera and Edge.

Status update (16.12.2016): We've been testing and using CKEditor 5 in Chrome, Safari, Firefox (51+ with enabled selection change events) and Opera – the level of stability is satisfactory as for this stage. We're planning to work on Edge support during next months.

Status update (18.04.2017): The editor works really stable on Chrome, Opera, Firefox and Safari. There are a lot of issues with Edge (you can follow them there – #423) though...

List of known issues:

Low priority:

@Reinmar Reinmar added this to the 0.2.0 milestone Jun 13, 2016

@Reinmar Reinmar modified the milestones: iteration 3, iteration 2 Jul 6, 2016

@Reinmar

This comment has been minimized.

Copy link
Member Author

Reinmar commented Jul 29, 2016

There's a separate discussion about browser support in: ckeditor/ckeditor5-design#156.

In this ticket, which is assigned to iteration 3, I'd propose to work only on support for the modern browsers and only for desktop (though, we see that editor works on most mobile ones too):

  1. Chrome and Opera.
  2. Firefox.
  3. Safari.
  4. Edge.

In all cases, we should support only the latest version.

Support for IE11, which according to current ideas expressed in #236 is a must have, will be added later. I think, though, that we should make a review of how CKEditor works on it now to have a better understanding of what will need to be done in the future. This is part of this task as well.

@Reinmar

This comment has been minimized.

Copy link
Member Author

Reinmar commented Aug 16, 2016

The first thing we need to do is checking what's the actual status. This should involve running automated and manual tests and a few minutes of normal editor usage on every browser.

@Reinmar

This comment has been minimized.

Copy link
Member Author

Reinmar commented Aug 16, 2016

First thing that needs to be done is adding --es5 option to the compiler so it produces ES5 compatible code.

@maxbarnas

This comment has been minimized.

Copy link
Contributor

maxbarnas commented Aug 19, 2016

After updating tests (ckeditor/ckeditor5-utils#2) and turning on transpilation to ES5 Chrome has 1 error, Safari has 39 (down from 154) and Edge has 45 (down from being untestable).

BTW, babel-plugin-transform-builtin-extend seems to work quite well, which renders our CKEditorError.isCKEditorError() quite useless in terms of dealing with transpilation problems.

@maxbarnas

This comment has been minimized.

Copy link
Contributor

maxbarnas commented Aug 26, 2016

Update

Problem with isSurrogateHalf() function is present on all browsers. Babel's fault seems to be evident.

The need for helper to compare HTML output is real. Firefox and Edge breaks the most because of it. Another problems shared between Edge and Firefox is dataprocessor/xmldataprocessor and view/observer/selectionobserver; they seem to break on both browsers.

@Reinmar

This comment has been minimized.

Copy link
Member Author

Reinmar commented Aug 26, 2016

Problem with isSurrogateHalf() function is present on all browsers. Babel's fault seems to be evident.

Could you elaborate on that? I don't think that you've mentioned this issue before.

@maxbarnas

This comment has been minimized.

Copy link
Contributor

maxbarnas commented Aug 26, 2016

The isSurrogateHalf() function is the place, where Babel translates unicode code points in regex expression to some mangled characters, that make no sense.

It is explained better in ckeditor/ckeditor5-utils#66 (comment).

@Reinmar

This comment has been minimized.

Copy link
Member Author

Reinmar commented Apr 18, 2017

Let's close this ticket. The editor works really stable on Chrome, Opera, Firefox and Safari. There are a lot of issues with Edge (you can follow them there – #423) though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.