Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation #3031

Closed
Reinmar opened this issue Apr 21, 2016 · 1 comment · Fixed by ckeditor/ckeditor5-typing#8
Closed

Initial implementation #3031

Reinmar opened this issue Apr 21, 2016 · 1 comment · Fixed by ckeditor/ckeditor5-typing#8
Assignees
Labels
package:typing type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 21, 2016

We can start with support for letter a-c. We'll add more letters later.

@Reinmar Reinmar self-assigned this Apr 21, 2016
@Reinmar
Copy link
Member Author

Reinmar commented Apr 22, 2016

In ckeditor/ckeditor5-typing#3 and ckeditor/ckeditor5-typing#4 we'll handle more complex cases like composition and autocorrection. In this ticket we'll focus on handle simple typing.

This will be done through our mutation observer which is an interface over the native one, so it gives us already preprocessed mutations.

As it seems now there will be two types of mutations that we need to handle:

  1. Simple text change.
  2. Whole text node insertion (so a children change).

The first case is very straightforward. The second one will require a bit more work I think.

Another thing that we need to handle is typing over non-collapsed selection. As we don't want to let the browser delete content when inserting the letter, we need to handle this by ourselves. The plan is to make a list of safe keys which shouldn't modify the content and do nothing when those happen. The rest of the keys will trigger deleting the contents... and let's hope that we can make this heuristic precise enough.

@pjasiun pjasiun assigned pjasiun and unassigned Reinmar May 30, 2016
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-typing Oct 9, 2019
@mlewand mlewand added this to the v0.1.0 milestone Oct 9, 2019
@mlewand mlewand added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:typing labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:typing type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants