This repository has been archived by the owner on Nov 16, 2017. It is now read-only.
Extract rect position utility from BalloonPanelView #98
Comments
|
Makes sense, of course, if this code is duplicated. I'm only unsure whether it better fits |
This was referenced Dec 2, 2016
This was referenced Dec 6, 2016
This was referenced Oct 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This chunk of code should be extracted and/or wrapped into a handy API and become a utility under
ckeditor5-utils/src/dom.The mentioned code is helpful to position elements in DOM using
postion: absolute. For instance, if there are components in the "body" region of the editor, which are to be positioned with respect to another element, i.e. floating toolbar aligned to the editor, balloon aligned to the link in editable, tooltip aligned to the button in the toolbar, etc., this utility helps determining the absolute position (topandleftin CSS) which should be set to achieve the desired composition.It's not a trivial task because
element.getBoundingClientRectreturns a rect relative to the viewport, which is only useful when positioning withposition: fixed. So to work withpostion: absolute(relative to<body>), lots of things must be considered (like clientRect of<body>, scrolls of the window, etc.) to translate fixed–like position into absolute–like.I see some pieces of code repeating in various places (
StickyToolbarView,BalloonPanelView) and I think it's time to DRY.The text was updated successfully, but these errors were encountered: