This repository has been archived by the owner on Nov 16, 2017. It is now read-only.
t/126 Fixed: BalloonPanelView incorrectly attached in positioned parent. #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR totally breaks positioning on ckeditor5.github.io:
|
|
BTW, would be good to understand what you're doing in this PR. The commit message nor PR description gives no hint about that. |
|
TBH, I checked it and found out that it is actually wrong. OTOH, it's fixed in #98 constellation, which depends on t/126 branch, so I'd rather focus on that instead and ditch this PR. WDYT? |
|
OK, so I'm not going to test this PR in terms of correctness. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #126, #129.