Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify locale management in Controller.addCollection() #5241

Closed
oleq opened this issue Jul 29, 2016 · 0 comments · Fixed by ckeditor/ckeditor5-ui#53
Closed

Simplify locale management in Controller.addCollection() #5241

oleq opened this issue Jul 29, 2016 · 0 comments · Fixed by ckeditor/ckeditor5-ui#53
Assignees
@oleq
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 2

Comments

@oleq
Copy link
Member

oleq commented Jul 29, 2016

A followup of https://github.com/ckeditor/ckeditor5-ui/pull/50/files#r72650075 (#6).

At this moment the method accepts the locale directly addCollection( collectionName, locale ), while it could use this.view.locale instead.
@oleq oleq self-assigned this Jul 29, 2016
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 2 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:ui labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 2
Development

Successfully merging a pull request may close this issue.

t/52: Simplified Controller#addCollection locale management ckeditor/ckeditor5-ui
2 participants
@oleq @mlewand