Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Feature: Introduced BlockToolbar plugin. #392

Merged
merged 57 commits into from
May 30, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
8e074be
Introduced BlockToolbar plugin.
oskarwrobel May 18, 2018
85d490f
Added missing dev dependencies.
oskarwrobel May 18, 2018
660f62b
Moved blocktoolbar styles to correct directory.
May 18, 2018
970e357
Tests: Added very basic block toolbar manual test.
oskarwrobel May 18, 2018
6bb0a80
Changed `ltrs-toolbar-block-button` to `ck-toolbar-block-button`.
May 18, 2018
315c7a7
Added importing stylesheet to blocktoolbar view.
May 18, 2018
159dee0
Removed obsolete CSS properties.
May 18, 2018
113984e
Added extra class to blockToolbar.panelView.
May 18, 2018
136e116
Fix: Fixed NaN value in a case of missing line-height property.
oskarwrobel May 18, 2018
7fb9097
Tests: Removed unused code from MT.
oskarwrobel May 18, 2018
e45d69d
Tests: Changed sinon.reset() to sinon.resetHistory().
oskarwrobel May 18, 2018
808db85
Changed naming of block toolbar.
May 18, 2018
90186d3
Change: Changed block toolbar panel limiter.
oskarwrobel May 18, 2018
d7dd0b5
Tests: Improved block toolbar manual test.
oskarwrobel May 18, 2018
a9db7dd
Changed class name.
oskarwrobel May 18, 2018
bab9252
Typo.
May 18, 2018
2fce455
Removed duplicated icon.
oskarwrobel May 18, 2018
6f12abc
Docs: Improved API docs.
oskarwrobel May 18, 2018
92e3851
Tests: Added more toolbar items.
oskarwrobel May 18, 2018
567bc88
Added decorable method for checking if block toolbar is allowed + imp…
oskarwrobel May 18, 2018
fe875a5
Docs: Added missind event docs.
oskarwrobel May 18, 2018
421f1ca
Tests: Improved CC.
oskarwrobel May 18, 2018
33fd205
Docs: Fixed invalid link.
oskarwrobel May 18, 2018
904fcd9
Tests: Fixed test that not check anything.
oskarwrobel May 18, 2018
57beddc
Tests: Improved manual test.
oskarwrobel May 18, 2018
d3c75e0
Tests: Added test cases to manual test.
oskarwrobel May 18, 2018
bf0939c
Added missing dependencies.
oskarwrobel May 18, 2018
6a0f1ec
Tests: Made tests more bulletproof.
oskarwrobel May 18, 2018
2cdcee4
Tests: Used getComputedStyle mock instead of setting styles.
oskarwrobel May 19, 2018
eb6a3c4
Docs: Added EditorConfig docs.
oskarwrobel May 19, 2018
ff2c991
Focused toolbar on panel open.
oskarwrobel May 21, 2018
aed85eb
Tests: Added test case with external changes.
oskarwrobel May 21, 2018
d79ecdb
Allowed BlockToolbar to be displayed next to $block elements.
oskarwrobel May 21, 2018
6b0b6ce
Improved BlockToolbar vertical aligning.
oskarwrobel May 21, 2018
2b9b439
Changed BlockToolbar horizontal position.
oskarwrobel May 21, 2018
b7176d7
Improved checking if BlockToolbar is allowed to be displayed.
oskarwrobel May 22, 2018
48e8cce
Docs: Improved BlockToolbar general docs.
oskarwrobel May 22, 2018
ca02b84
Tests: Improved test names.
oskarwrobel May 22, 2018
0153af0
Improved BlockToolbar manual test.
oskarwrobel May 22, 2018
13cd9eb
Removed decorable method for disabling BlockToolbar.
oskarwrobel May 22, 2018
0a6bc44
Tests: Adjusted manual test to last changes in BlockToolbar.
oskarwrobel May 22, 2018
8052d29
Refactored handling read-only by BlockToolbar mode.
oskarwrobel May 22, 2018
685364c
Tests: Minor improvements in manual test.
oskarwrobel May 22, 2018
3e2cb20
Added missing dev dependency.
oskarwrobel May 22, 2018
1a6e145
Docs: Added missing view docs.
oskarwrobel May 22, 2018
b2aad6d
Added additional class to the ToolbarView in BlockToolbar.
oskarwrobel May 22, 2018
c05c836
Changed additional BalloonPanelView class.
oskarwrobel May 22, 2018
c241cc9
Hide BlockButton on init.
oskarwrobel May 23, 2018
bd8c2b3
Docs: Minor change.
oskarwrobel May 24, 2018
2b807fc
Tests: Changed test case of manual test.
oskarwrobel May 28, 2018
d0c8480
Docs: Removed obsolete event docs.
oskarwrobel May 28, 2018
ec3caaa
Docs: Improved docs in the BlockToolbar plugin.
oleq May 28, 2018
49b3538
Docs, Tests: Improved comments and manual test descriptions.
oleq May 28, 2018
b5ddbfd
Tests: Improved assertions in the BlockToolbar tests.
oleq May 28, 2018
a8e7cf4
Tests: Improved ButtonToolbar unit test descriptions.
oleq May 28, 2018
54ef26f
Moved BlockButtonView from the view directory.
oskarwrobel May 29, 2018
0e87365
Moved the pilcrow icon to the ckeditor5-core.
oleq May 30, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,18 @@
},
"devDependencies": {
"@ckeditor/ckeditor5-basic-styles": "^10.0.0",
"@ckeditor/ckeditor5-block-quote": "^10.0.0",
"@ckeditor/ckeditor5-cloud-services": "^10.0.0",
"@ckeditor/ckeditor5-editor-balloon": "^10.0.0",
"@ckeditor/ckeditor5-editor-classic": "^10.0.0",
"@ckeditor/ckeditor5-engine": "^10.0.0",
"@ckeditor/ckeditor5-enter": "^10.0.0",
"@ckeditor/ckeditor5-easy-image": "^10.0.0",
"@ckeditor/ckeditor5-essentials": "^10.0.0",
"@ckeditor/ckeditor5-heading": "^10.0.0",
"@ckeditor/ckeditor5-image": "^10.0.0",
"@ckeditor/ckeditor5-link": "^10.0.0",
"@ckeditor/ckeditor5-list": "^10.0.0",
"@ckeditor/ckeditor5-paragraph": "^10.0.0",
"@ckeditor/ckeditor5-typing": "^10.0.0",
"@ckeditor/ckeditor5-undo": "^10.0.0",
Expand Down
60 changes: 60 additions & 0 deletions src/toolbar/block/blockbuttonview.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
/**
* Copyright (c) 2016 - 2017, CKSource - Frederico Knabben. All rights reserved.
*/

/**
* @module ui/toolbar/block/blockbuttonview
*/

import ButtonView from '../../button/buttonview';
import toUnit from '@ckeditor/ckeditor5-utils/src/dom/tounit';
import '../../../theme/components/toolbar/blocktoolbar.css';

const toPx = toUnit( 'px' );

/**
* The block button view class.
*
* This view represents a button attached next to block element where the selection is anchored.
*
* See {@link module:ui/toolbar/block/blocktoolbar~BlockToolbar}.
*
* @extends {module:ui/button/buttonview~ButtonView}
*/
export default class BlockButtonView extends ButtonView {
/**
* @inheritDoc
*/
constructor( locale ) {
super( locale );

const bind = this.bindTemplate;

// Hide button on init.
this.isVisible = false;

/**
* Top offset.
*
* @member {Number} #top
*/
this.set( 'top', 0 );

/**
* Left offset.
*
* @member {Number} #left
*/
this.set( 'left', 0 );

this.extendTemplate( {
attributes: {
class: 'ck-block-toolbar-button',
style: {
top: bind.to( 'top', val => toPx( val ) ),
left: bind.to( 'left', val => toPx( val ) ),
}
}
} );
}
}
Loading