Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Feature: Introduced skipping items when binging collections. #216

Merged
merged 3 commits into from Jan 9, 2018
Merged

Conversation

oskarwrobel
Copy link
Contributor

@oskarwrobel oskarwrobel commented Jan 8, 2018

Suggested merge commit message (convention)

Feature: Introduced skipping items when binging collections. Closes ckeditor/ckeditor5#4990. Closes https://github.com/ckeditor/ckeditor5-ui/issues/92.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 79ee2fc on t/215 into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 19c9905 on t/215 into ** on master**.

@oskarwrobel
Copy link
Contributor Author

I probably found a bug.

@oskarwrobel
Copy link
Contributor Author

Fixed (missing index for initial items).

                // Load the initial content of the collection.
                for ( const externalItem of externalCollection ) {
-                       addItem( null, externalItem );
+                       addItem( null, externalItem, externalCollection.getIndex( externalItem ) );
                }

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 24db40a on t/215 into ** on master**.

@pjasiun pjasiun merged commit 6e0d063 into master Jan 9, 2018
@pjasiun pjasiun deleted the t/215 branch January 9, 2018 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants