Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#153: The editor should now slow down with lots of content when using the integration #156

Merged
merged 1 commit into from Sep 18, 2020
Merged

#153: The editor should now slow down with lots of content when using the integration #156

merged 1 commit into from Sep 18, 2020

Conversation

oleq
Copy link
Member

@oleq oleq commented Sep 17, 2020

Suggested merge commit message (convention)

Fix: The editor should now slow down with lots of content when using the integration. Closes #153.

@oleq
Renamed #instance to in component data to exclude the editor instance…
ad5afb4 
… object from internal Vue processing and thus improve performance.
@oleq oleq mentioned this pull request Sep 17, 2020
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 135

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 130: 0.0%
Covered Lines: 31
Relevant Lines: 31
💛 - Coveralls

@marcellofuschi
Copy link

I tested it and it looks like this PR fixes the performance issue.

pomek
pomek approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pomek pomek merged commit df4410a into master Sep 18, 2020
@pomek pomek deleted the i/153-performance branch September 18, 2020 11:18
@marcellofuschi marcellofuschi mentioned this pull request Sep 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomek pomek pomek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The editor slows down with lots of content, and only with ckeditor5-vue
4 participants
@oleq @coveralls @marcellofuschi @pomek