New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue 3.x support #160
Vue 3.x support #160
Conversation
Pull Request Test Coverage Report for Build 179
💛 - Coveralls |
There are some strange errors in CI build:
@pomek @oleq Have you ever seen them before? |
The following things will have to be done before merging this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me except for the "Executing tests" section of the README.md
file. The configuration options listed there no longer make sense and some new scripts (like npm run coverage
) were included so I think it's worth updating.
If bringing support for test watcher or reporter options is a big issue now, let's drop the support for these. We can always get back and implement them and they're not critical for a small project like this one.
|
Closed as the proposal to re-use one codebase for both Vue versions is not ideal and requires some hacks to work properly. |
Suggested merge commit message (convention)
Feature: Added support for Vue 3.x. Closes #158.
Internal: Merged code coverage reports from test runs from both Vue versions before sending them to Coveralls. Closes #162.
BREAKING CHANGE: Now, the CKEditor is a function that accepts an object as its one and only argument with the
version
property. For Vue 3.x also theh
function is required during initialization and it must be passed to this object argument.BREAKING CHANGE: The prop name used by
v-model
directive has changed fromvalue
tomodel-value
.