Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning message for not supported Vue version #171

Merged
merged 1 commit into from Nov 23, 2020
Merged

Show warning message for not supported Vue version #171

merged 1 commit into from Nov 23, 2020

Conversation

psmyrek
Copy link
Contributor

@psmyrek psmyrek commented Nov 21, 2020

Suggested merge commit message (convention)

Fix: Show warning message for not supported Vue version. Closes #170.


Additional information

Previously it only detected unsupported Vue version for direct script include. The detection didn't work if project was setup using Vue CLI. Now it works in both cases.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 209

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 206: 0.0%
Covered Lines: 34
Relevant Lines: 34

💛 - Coveralls

Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pomek pomek merged commit 300f301 into master Nov 23, 2020
@pomek pomek deleted the i/170 branch November 23, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect error message after using package with Vue 2.x
4 participants