Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue for vue 3.2.x #216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidmeirlevy
Copy link

Suggested merge commit message (convention)

Type: Message. Closes #000.


Additional information

from vue 3.2.x - every property on the data becomes reactive() and not ref(), and since that version - every getter from the reactive proxy returns a reactive proxy of the internal property.
because of that, using methods under the instance is throwing errors because the "this" context is the proxy and not the instance.

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@davidmeirlevy
Copy link
Author

@Reinmar your CLA form is broken. tells me the address input is required although I filled it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 253

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 251: 0.0%
Covered Lines: 44
Relevant Lines: 44

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants