This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Use proper method to map a view to a DOM element in getBalloonPositio… #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleq
suggested changes
Jun 25, 2019
| @@ -243,7 +243,7 @@ function getBalloonPositionData( editor, relatedElement ) { | |||
| const defaultPositions = BalloonPanelView.defaultPositions; | |||
|
|
|||
| return { | |||
| target: editingView.domConverter.viewToDom( relatedElement ), | |||
| target: editingView.domConverter.mapViewToDom( relatedElement ), | |||
There was a problem hiding this comment.
I'm trying to write a test for this. And the only case when this fails if the getRelatedElement() will return an object with API similar to view element (ie Model's Element) and the viewToDom will try to create a DOM node and somehow the domDocument is null. I'm lost how to write a test for this.
Also, this issue is really about the wrong method use with wrong parameters. Also changing viewToDom to proper mapViewToDom does not fix the issue with wrong API use.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use proper method to map a view to a DOM element in getBalloonPositionData().
Suggested merge commit message (convention)
Fix: Use proper method to map a view to a DOM element when getting balloon position data. Closes ckeditor/ckeditor5#4608.
Additional information