Remove return types from 'require()' methods.

ckeditor · Mar 20, 2023 · 1c48986 · 1c48986
1 parent e0a26ae
commit 1c48986
Show file tree

Hide file tree

Showing 151 changed files with 459 additions and 464 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -26,6 +26,17 @@ module.exports = {
 		} ]
 	},
 	overrides: [
+		{
+			files: [ '**/*.ts' ],
+			rules: {
+				'@typescript-eslint/explicit-module-boundary-types': [
+					'error',
+					{
+						'allowedNames': [ 'requires' ]
+					}
+				]
+			}
+		},
 		{
 			files: [ '**/tests/**/*.js' ],
 			rules: {

diff --git a/packages/ckeditor5-adapter-ckfinder/src/uploadadapter.ts b/packages/ckeditor5-adapter-ckfinder/src/uploadadapter.ts
@@ -9,7 +9,7 @@
  * @module adapter-ckfinder/uploadadapter
  */
 
-import { Plugin, type PluginDependencies } from 'ckeditor5/src/core';
+import { Plugin } from 'ckeditor5/src/core';
 import {
 	FileRepository,
 	type UploadAdapter as UploadAdapterInterface,
@@ -34,8 +34,8 @@ export default class CKFinderUploadAdapter extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ FileRepository ];
+	public static get requires() {
+		return [ FileRepository ] as const;
 	}
 
 	/**

diff --git a/packages/ckeditor5-alignment/src/alignment.ts b/packages/ckeditor5-alignment/src/alignment.ts
@@ -7,7 +7,7 @@
  * @module alignment/alignment
  */
 
-import { Plugin, type PluginDependencies } from 'ckeditor5/src/core';
+import { Plugin } from 'ckeditor5/src/core';
 
 import AlignmentEditing from './alignmentediting';
 import AlignmentUI from './alignmentui';
@@ -25,8 +25,8 @@ export default class Alignment extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ AlignmentEditing, AlignmentUI ];
+	public static get requires() {
+		return [ AlignmentEditing, AlignmentUI ] as const;
 	}
 
 	/**

diff --git a/packages/ckeditor5-autoformat/src/autoformat.ts b/packages/ckeditor5-autoformat/src/autoformat.ts
@@ -8,7 +8,7 @@
  */
 import type { HeadingCommand } from '@ckeditor/ckeditor5-heading';
 
-import { Plugin, type PluginDependencies, type Editor } from 'ckeditor5/src/core';
+import { Plugin, type Editor } from 'ckeditor5/src/core';
 import type { Range, Writer } from 'ckeditor5/src/engine';
 import { Delete } from 'ckeditor5/src/typing';
 
@@ -25,8 +25,8 @@ export default class Autoformat extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ Delete ];
+	public static get requires() {
+		return [ Delete ] as const;
 	}
 
 	/**

diff --git a/packages/ckeditor5-autosave/src/autosave.ts b/packages/ckeditor5-autosave/src/autosave.ts
@@ -10,7 +10,6 @@
 import {
 	Plugin,
 	PendingActions,
-	type PluginDependencies,
 	type Editor,
 	type PendingAction,
 	type EditorDestroyEvent,
@@ -136,8 +135,8 @@ export default class Autosave extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ PendingActions ];
+	public static get requires() {
+		return [ PendingActions ] as const;
 	}
 
 	/**

diff --git a/packages/ckeditor5-basic-styles/src/bold.ts b/packages/ckeditor5-basic-styles/src/bold.ts
@@ -7,7 +7,7 @@
  * @module basic-styles/bold
  */
 
-import { Plugin, type PluginDependencies } from 'ckeditor5/src/core';
+import { Plugin } from 'ckeditor5/src/core';
 import BoldEditing from './bold/boldediting';
 import BoldUI from './bold/boldui';
 
@@ -24,8 +24,8 @@ export default class Bold extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ BoldEditing, BoldUI ];
+	public static get requires() {
+		return [ BoldEditing, BoldUI ] as const;
 	}
 
 	/**

diff --git a/packages/ckeditor5-basic-styles/src/code.ts b/packages/ckeditor5-basic-styles/src/code.ts
@@ -7,7 +7,7 @@
  * @module basic-styles/code
  */
 
-import { Plugin, type PluginDependencies } from 'ckeditor5/src/core';
+import { Plugin } from 'ckeditor5/src/core';
 import CodeEditing from './code/codeediting';
 import CodeUI from './code/codeui';
 
@@ -26,8 +26,8 @@ export default class Code extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ CodeEditing, CodeUI ];
+	public static get requires() {
+		return [ CodeEditing, CodeUI ] as const;
 	}
 
 	/**

diff --git a/packages/ckeditor5-basic-styles/src/code/codeediting.ts b/packages/ckeditor5-basic-styles/src/code/codeediting.ts
@@ -7,7 +7,7 @@
  * @module basic-styles/code/codeediting
  */
 
-import { Plugin, type PluginDependencies } from 'ckeditor5/src/core';
+import { Plugin } from 'ckeditor5/src/core';
 import { TwoStepCaretMovement, inlineHighlight } from 'ckeditor5/src/typing';
 
 import AttributeCommand from '../attributecommand';
@@ -32,8 +32,8 @@ export default class CodeEditing extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ TwoStepCaretMovement ];
+	public static get requires() {
+		return [ TwoStepCaretMovement ] as const;
 	}
 
 	/**

diff --git a/packages/ckeditor5-basic-styles/src/italic.ts b/packages/ckeditor5-basic-styles/src/italic.ts
@@ -7,7 +7,7 @@
  * @module basic-styles/italic
  */
 
-import { Plugin, type PluginDependencies } from 'ckeditor5/src/core';
+import { Plugin } from 'ckeditor5/src/core';
 import ItalicEditing from './italic/italicediting';
 import ItalicUI from './italic/italicui';
 
@@ -24,8 +24,8 @@ export default class Italic extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ ItalicEditing, ItalicUI ];
+	public static get requires() {
+		return [ ItalicEditing, ItalicUI ] as const;
 	}
 
 	/**

diff --git a/packages/ckeditor5-basic-styles/src/strikethrough.ts b/packages/ckeditor5-basic-styles/src/strikethrough.ts
@@ -7,7 +7,7 @@
  * @module basic-styles/strikethrough
  */
 
-import { Plugin, type PluginDependencies } from 'ckeditor5/src/core';
+import { Plugin } from 'ckeditor5/src/core';
 import StrikethroughEditing from './strikethrough/strikethroughediting';
 import StrikethroughUI from './strikethrough/strikethroughui';
 
@@ -24,8 +24,8 @@ export default class Strikethrough extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ StrikethroughEditing, StrikethroughUI ];
+	public static get requires() {
+		return [ StrikethroughEditing, StrikethroughUI ] as const;
 	}
 
 	/**

diff --git a/packages/ckeditor5-basic-styles/src/subscript.ts b/packages/ckeditor5-basic-styles/src/subscript.ts
@@ -7,7 +7,7 @@
  * @module basic-styles/subscript
  */
 
-import { Plugin, type PluginDependencies } from 'ckeditor5/src/core';
+import { Plugin } from 'ckeditor5/src/core';
 import SubscriptEditing from './subscript/subscriptediting';
 import SubscriptUI from './subscript/subscriptui';
 
@@ -21,8 +21,8 @@ export default class Subscript extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ SubscriptEditing, SubscriptUI ];
+	public static get requires() {
+		return [ SubscriptEditing, SubscriptUI ] as const;
 	}
 
 	/**

diff --git a/packages/ckeditor5-basic-styles/src/superscript.ts b/packages/ckeditor5-basic-styles/src/superscript.ts
@@ -7,7 +7,7 @@
  * @module basic-styles/superscript
  */
 
-import { Plugin, type PluginDependencies } from 'ckeditor5/src/core';
+import { Plugin } from 'ckeditor5/src/core';
 import SuperscriptEditing from './superscript/superscriptediting';
 import SuperscriptUI from './superscript/superscriptui';
 
@@ -21,8 +21,8 @@ export default class Superscript extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ SuperscriptEditing, SuperscriptUI ];
+	public static get requires() {
+		return [ SuperscriptEditing, SuperscriptUI ] as const;
 	}
 
 	/**

diff --git a/packages/ckeditor5-basic-styles/src/underline.ts b/packages/ckeditor5-basic-styles/src/underline.ts
@@ -7,7 +7,7 @@
  * @module basic-styles/underline
  */
 
-import { Plugin, type PluginDependencies } from 'ckeditor5/src/core';
+import { Plugin } from 'ckeditor5/src/core';
 import UnderlineEditing from './underline/underlineediting';
 import UnderlineUI from './underline/underlineui';
 
@@ -24,8 +24,8 @@ export default class Underline extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ UnderlineEditing, UnderlineUI ];
+	public static get requires() {
+		return [ UnderlineEditing, UnderlineUI ] as const;
 	}
 
 	/**

diff --git a/packages/ckeditor5-block-quote/src/blockquote.ts b/packages/ckeditor5-block-quote/src/blockquote.ts
@@ -7,7 +7,7 @@
  * @module block-quote/blockquote
  */
 
-import { Plugin, type PluginDependencies } from 'ckeditor5/src/core';
+import { Plugin } from 'ckeditor5/src/core';
 
 import BlockQuoteEditing from './blockquoteediting';
 import BlockQuoteUI from './blockquoteui';
@@ -26,8 +26,8 @@ export default class BlockQuote extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ BlockQuoteEditing, BlockQuoteUI ];
+	public static get requires() {
+		return [ BlockQuoteEditing, BlockQuoteUI ] as const;
 	}
 
 	/**

diff --git a/packages/ckeditor5-block-quote/src/blockquoteediting.ts b/packages/ckeditor5-block-quote/src/blockquoteediting.ts
@@ -7,7 +7,7 @@
  * @module block-quote/blockquoteediting
  */
 
-import { Plugin, type PluginDependencies } from 'ckeditor5/src/core';
+import { Plugin } from 'ckeditor5/src/core';
 import { Enter, type ViewDocumentEnterEvent } from 'ckeditor5/src/enter';
 import { Delete, type ViewDocumentDeleteEvent } from 'ckeditor5/src/typing';
 
@@ -31,8 +31,8 @@ export default class BlockQuoteEditing extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ Enter, Delete ];
+	public static get requires() {
+		return [ Enter, Delete ] as const;
 	}
 
 	/**

diff --git a/packages/ckeditor5-ckbox/src/ckbox.ts b/packages/ckeditor5-ckbox/src/ckbox.ts
@@ -7,7 +7,7 @@
  * @module ckbox/ckbox
  */
 
-import { Plugin, type PluginDependencies } from 'ckeditor5/src/core';
+import { Plugin } from 'ckeditor5/src/core';
 
 import CKBoxUI from './ckboxui';
 import CKBoxEditing from './ckboxediting';
@@ -36,7 +36,7 @@ export default class CKBox extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ CKBoxEditing, CKBoxUI ];
+	public static get requires() {
+		return [ CKBoxEditing, CKBoxUI ] as const;
 	}
 }
diff --git a/packages/ckeditor5-ckbox/src/ckboxediting.ts b/packages/ckeditor5-ckbox/src/ckboxediting.ts
@@ -10,7 +10,7 @@
  */
 
 import type { CloudServices, CloudServicesCore, InitializedToken } from '@ckeditor/ckeditor5-cloud-services';
-import { Plugin, type Editor, type PluginDependencies } from 'ckeditor5/src/core';
+import { Plugin, type Editor } from 'ckeditor5/src/core';
 import {
 	Range,
 	type DocumentSelection,
@@ -50,8 +50,8 @@ export default class CKBoxEditing extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ 'CloudServices', 'LinkEditing', 'PictureEditing', CKBoxUploadAdapter ];
+	public static get requires() {
+		return [ 'CloudServices', 'LinkEditing', 'PictureEditing', CKBoxUploadAdapter ] as const;
 	}
 
 	/**

diff --git a/packages/ckeditor5-ckbox/src/ckboxuploadadapter.ts b/packages/ckeditor5-ckbox/src/ckboxuploadadapter.ts
@@ -9,7 +9,7 @@
  * @module ckbox/ckboxuploadadapter
  */
 
-import { Plugin, type Editor, type PluginDependencies } from 'ckeditor5/src/core';
+import { Plugin, type Editor } from 'ckeditor5/src/core';
 import {
 	FileRepository,
 	type FileLoader,
@@ -37,8 +37,8 @@ export default class CKBoxUploadAdapter extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ 'ImageUploadEditing', 'ImageUploadProgress', FileRepository, CKBoxEditing ];
+	public static get requires() {
+		return [ 'ImageUploadEditing', 'ImageUploadProgress', FileRepository, CKBoxEditing ] as const;
 	}
 
 	/**

diff --git a/packages/ckeditor5-ckfinder/src/ckfinder.ts b/packages/ckeditor5-ckfinder/src/ckfinder.ts
@@ -7,7 +7,7 @@
  * @module ckfinder/ckfinder
  */
 
-import { Plugin, type PluginDependencies } from 'ckeditor5/src/core';
+import { Plugin } from 'ckeditor5/src/core';
 
 import CKFinderUI from './ckfinderui';
 import CKFinderEditing from './ckfinderediting';
@@ -39,7 +39,7 @@ export default class CKFinder extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ 'Link', 'CKFinderUploadAdapter', CKFinderEditing, CKFinderUI ];
+	public static get requires() {
+		return [ 'Link', 'CKFinderUploadAdapter', CKFinderEditing, CKFinderUI ] as const;
 	}
 }
diff --git a/packages/ckeditor5-ckfinder/src/ckfinderediting.ts b/packages/ckeditor5-ckfinder/src/ckfinderediting.ts
@@ -7,7 +7,7 @@
  * @module ckfinder/ckfinderediting
  */
 
-import { Plugin, type PluginDependencies } from 'ckeditor5/src/core';
+import { Plugin } from 'ckeditor5/src/core';
 import { Notification } from 'ckeditor5/src/ui';
 import { CKEditorError } from 'ckeditor5/src/utils';
 
@@ -27,8 +27,8 @@ export default class CKFinderEditing extends Plugin {
 	/**
 	 * @inheritDoc
 	 */
-	public static get requires(): PluginDependencies {
-		return [ Notification, 'LinkEditing' ];
+	public static get requires() {
+		return [ Notification, 'LinkEditing' ] as const;
 	}
 
 	/**