Skip to content

Commit

Permalink
Merge pull request #15606 from ckeditor/ck/5834-ckbox-image-editing-s…
Browse files Browse the repository at this point in the history
…hould-work-with-different-service-origin

Other (ckbox): Image editing should work with on-premise CKBox. Closes #5834.
  • Loading branch information
arkflpc committed Jan 4, 2024
2 parents ee2b91c + 0de9280 commit ec2d705
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
Expand Up @@ -176,6 +176,7 @@ export default class CKBoxImageEditCommand extends Command {
allowOverwrite: false
},
tokenUrl: ckboxConfig.tokenUrl,
...( ckboxConfig.serviceOrigin && { serviceOrigin: ckboxConfig.serviceOrigin } ),
onClose: () => this._handleImageEditorClose(),
onSave: ( asset: CKBoxRawAssetDefinition ) => this._handleImageEditorSave( state, asset )
};
Expand Down
Expand Up @@ -234,6 +234,7 @@ describe( 'CKBoxImageEditCommand', () => {
} );

expect( options ).to.have.property( 'assetId', ckboxImageId );
expect( options ).to.have.property( 'serviceOrigin', CKBOX_API_URL );
expect( options ).to.have.property( 'tokenUrl', 'foo' );
expect( options.imageEditing.allowOverwrite ).to.be.false;
expect( options.onSave ).to.be.a( 'function' );
Expand Down

0 comments on commit ec2d705

Please sign in to comment.