Merge pull request #11475 from ckeditor/cf/4302

Other: Improved performance of the `getSubNodes()` utility of `Watchdog`.
ckeditor · Mar 28, 2022 · ee63f39 · ee63f39
2 parents 085b29b + 8c195fd
commit ee63f39
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/ckeditor5-watchdog/src/utils/getsubnodes.js b/packages/ckeditor5-watchdog/src/utils/getsubnodes.js
@@ -16,9 +16,11 @@ export default function getSubNodes( head, excludedProperties = new Set() ) {
 
 	// Nodes are stored to prevent infinite looping.
 	const subNodes = new Set();
+	let nodeIndex = 0;
 
-	while ( nodes.length > 0 ) {
-		const node = nodes.shift();
+	while ( nodes.length > nodeIndex ) {
+		// Incrementing the iterator is much faster than changing size of the array with Array.prototype.shift().
+		const node = nodes[ nodeIndex++ ];
 
 		if ( subNodes.has( node ) || shouldNodeBeSkipped( node ) || excludedProperties.has( node ) ) {
 			continue;