Merge pull request #14424 from ckeditor/ck/14361-new-color-picker-sub…

…mits-form Fix (font): The accept button in the color picker will no longer submit forms . Closes #14361.
ckeditor · Jun 20, 2023 · eff5cca · eff5cca
2 parents 74c507c + 196660e
commit eff5cca
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/ckeditor5-font/src/ui/colortableview.ts b/packages/ckeditor5-font/src/ui/colortableview.ts
@@ -1002,7 +1002,7 @@ class ColorPickerPageView extends View {
 			class: 'ck-button-save',
 			withText: false,
 			label: t( 'Accept' ),
-			type: 'submit'
+			type: 'button'
 		} );
 
 		cancelButtonView.set( {

diff --git a/packages/ckeditor5-font/tests/ui/colortableview.js b/packages/ckeditor5-font/tests/ui/colortableview.js
@@ -519,6 +519,10 @@ describe( 'ColorTableView', () => {
 				expect( saveButton.element.classList.contains( 'ck-button-save' ) ).to.be.true;
 			} );
 
+			it( 'should have a proper type', () => {
+				expect( saveButton.type ).to.be.equal( 'button' );
+			} );
+
 			it( 'should have proper settings', () => {
 				expect( saveButton.withText ).to.be.false;
 				expect( saveButton.icon ).to.equal( icons.check );