Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add the "accessibility instructions" modal #1014

Closed
Kataract opened this issue May 7, 2018 · 6 comments · Fixed by #15702
Closed

Re-add the "accessibility instructions" modal #1014

Kataract opened this issue May 7, 2018 · 6 comments · Fixed by #15702
Assignees
Labels
domain:accessibility This issue reports an accessibility problem. squad:features Issue to be handled by the Features team. status:discussion support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@Kataract
Copy link

Kataract commented May 7, 2018

Is this a bug report or feature request? (choose one)

🆕 Feature request

💻 Version of CKEditor

CKEditor 5 builds

📋 Steps to reproduce

  1. Press alt+0 while in the text area (which used to bring up the accessibility instructions modal in CKE4)

✅ Expected result

Accessibility instructions modal pops up

❎ Actual result

I get a degrees symbol on my Mac inserted in the text area 😅


If you'd like to see this feature implemented, add a 👍 reaction to this post.

@Reinmar
Copy link
Member

Reinmar commented May 14, 2018

Thanks for the report. Indeed, CKEditor 4 has such a modal:

image

We may need a similar one for CKEditor 5.

I wonder, though, how many apps handle Alt+0? I checked a couple of places (GH, Slack, Google Docs) and none of them showed anything. Does that mean that they don't implement some important accessibility feature? Or is such a modal something specific for CKEditor 4?

cc @Comandeer @oleq @dkonopka

@Reinmar Reinmar added status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option). labels May 14, 2018
@Reinmar Reinmar added this to the unknown milestone May 14, 2018
@oleq
Copy link
Member

oleq commented May 15, 2018

Both Gmail and GitHub implement this feature, but it's under ⇧ Shift+/ (or simply ?) which only makes sense when there's no focus in the text input field, which, again, does not make any sense in a text editor ;-) Also kepp in mind that, as complete ecosystems, these applications have more freedom when it comes to selecting keystrokes.

That's most likely why we used Alt+0 in v4.

P.S. In Slack it is under +/.

image

image

image

@mlewand mlewand added the domain:accessibility This issue reports an accessibility problem. label Jul 15, 2019
@mlewand
Copy link
Contributor

mlewand commented Jul 15, 2019

There are many variations, but most commonly apps use / key today (as opposed to F1 back in a day 🙂).

As @oleq mentioned there are apps using shift+/, I know it's also used in Chrome devtools. alt+/ is also true for GitHub, Bitbucket. ctrl+/ or cmd+/ is used in Slack, Gdocs.

IMO the best option for us is ctrl+/ or cmd+/. Actually this is also happens to be a hotkey that we were planning to use in CKE4 keystrokes dialog.

@lslowikowska lslowikowska added the support:2 An issue reported by a commercially licensed client. label Jul 28, 2021
@pomek pomek removed this from the unknown milestone Feb 21, 2022
@Comandeer Comandeer added the squad:features Issue to be handled by the Features team. label May 27, 2022
@Comandeer
Copy link
Member

It'd be also good to make it discoverable also for non-screen-reader users, especially:

  • mouse/touch users – in this case, a toolbar button should be enough,
  • keyboard-only users – I don't have a good idea for that one… Maybe display the info for screen readers also in form of some popup info in the editor when it's keyboard-focused for the first time?

@s-at-dq
Copy link

s-at-dq commented Jun 3, 2022

Regarding the shortcut for the modal help dialog:

  • The screen reader Orca uses the 0 key for opening context menus (right click menus).
  • Depending on the keyboard layout, the key for slash ("/") is only available using the shift key or another modifier.
    • On the standard german layout, you need to press Shift + 7 to get it.
    • On neo2, you need to press Mod3 + I.

@raq007
Copy link

raq007 commented Sep 7, 2023

+1 to the feature request.

@oleq oleq self-assigned this Jan 23, 2024
oleq added a commit that referenced this issue Feb 26, 2024
Feature (ui): Implemented the `AccessibilityHelp` plugin that brings a dialog displaying keyboard shortcuts available in the editor. Closes #1014.

Feature (core): Brought the `editor.accessibility` namespace to the base `Editor` class as a container for accessibility-related features and systems. See #1014.

Other (essentials): Enabled the `AccessibilityHelp` plugin by default. See #1014.

Fix (utils): The exported `keyCodes` object should contain correct codes for keys related to punctuation, brackets, braces, etc. See #1014.
@CKEditorBot CKEditorBot added this to the iteration 72 milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:accessibility This issue reports an accessibility problem. squad:features Issue to be handled by the Features team. status:discussion support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants