Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PluginCollection: Check whether all plugins are accessible by their names #121

Closed
Reinmar opened this issue Mar 15, 2016 · 0 comments
Closed

PluginCollection: Check whether all plugins are accessible by their names #121

Reinmar opened this issue Mar 15, 2016 · 0 comments
Assignees
@oskarwrobel
Labels
intro Good first ticket. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
v0.1.0

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 15, 2016

Moved from ckeditor/ckeditor5-core#174

While writing the docs I think I found a bug (I haven't checked it though). In this example:

CKEDITOR.create( '#editor', {
    features: 'A,B,C,D,E'
} );

When the B plugin requires C, it may happen that C will not be accessible by its name (plugins.get( 'C' )). That may happen due to the fact that C was loaded by a class. The fix should be quite easy – once trying to load by name a plugin which is already being loaded save also its name.
@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. module:app labels Mar 15, 2016
@Reinmar Reinmar added the intro Good first ticket. label May 10, 2016
@oskarwrobel oskarwrobel self-assigned this May 11, 2016
@oskarwrobel oskarwrobel mentioned this issue May 12, 2016
Merged
@Reinmar Reinmar modified the milestone: 0.1.0 May 17, 2016
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge pull request #121 from ckeditor/i/6536
414f64b 
Other: Moved the <kbd>Ctrl</kbd>+<kbd>A</kbd> keystroke handling in widgets to the [`SelectAll`](https://ckeditor.com/docs/ckeditor5/latest/api/module_select-all_selectall-SelectAll.html) plugin (see #6536).

MINOR BREAKING CHANGE: Make sure the latest version of the [`Essentials`](https://ckeditor.com/docs/ckeditor5/latest/api/essentials.html) plugin or the [`SelectAll`](https://ckeditor.com/docs/ckeditor5/latest/api/module_select-all_selectall-SelectAll.html) plugin is installed in your integration. Either is required for proper keystroke handling in editor widgets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarwrobel oskarwrobel

Labels
intro Good first ticket. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
2 participants
@Reinmar @oskarwrobel