Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not possible to insert image URL with keyboard #12215

Closed
mmotyczynska opened this issue Aug 3, 2022 · 2 comments · Fixed by #12415
Closed

Not possible to insert image URL with keyboard #12215

mmotyczynska opened this issue Aug 3, 2022 · 2 comments · Fixed by #12415
Assignees
@mmotyczynska
Labels
domain:accessibility This issue reports an accessibility problem. package:image squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 57 (v35...

Comments

@mmotyczynska
Copy link
Contributor

mmotyczynska commented Aug 3, 2022 •
edited by mlewand

📝 Provide detailed reproduction steps (if any)

  1. Open editor with Insert Image feature, e.g. https://ckeditor.com/docs/ckeditor5/30.0.0/features/images/image-upload/images-inserting.html
  2. Navigate to toolbar with keyboard (alt/opt + F10)
  3. Navigate to Insert Image button with arrow keys
  4. Press arrow down to open the dropdown

✔️ Expected result

The dropdown opens and is fully visible.

Screen.Recording.2022-08-03.at.14.51.45.mov

❌ Actual result

The dropdown opens but is empty.

Screen.Recording.2022-08-03.at.14.12.41.mov

❓ Possible solution

According to @oleq it's likely that rendering is done in execute event.

However, pressing down arrow doesn't cause execute event (unlike space and enter key).

If that's the case we should simply fire execute event as well (for down arrow too) to make sure that other/future implementations doesn't fall into the same issue.

📃 Other details

Be sure to check whether nothing in CF broke after this.

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@mmotyczynska mmotyczynska added type:bug This issue reports a buggy (incorrect) behavior. package:image labels Aug 3, 2022
@Reinmar Reinmar added the domain:accessibility This issue reports an accessibility problem. label Aug 3, 2022
@Reinmar
Copy link
Member

Reinmar commented Aug 3, 2022

Is it a regression?

@mmotyczynska
Copy link
Contributor Author

No, it's not a regression.

@mlewand mlewand added the squad:features Issue to be handled by the Features team. label Aug 30, 2022
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. and removed squad:features Issue to be handled by the Features team. labels Aug 30, 2022
@mlewand mlewand added the squad:features Issue to be handled by the Features team. label Sep 2, 2022
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Sep 2, 2022
@mmotyczynska mmotyczynska mentioned this issue Sep 5, 2022
Merged
oleq added a commit that referenced this issue Sep 8, 2022
@oleq
Merge pull request #12415 from ckeditor/ck/12215-not-possible-to-inse…
3f415af 
…rt-image-url-with-keyboard

Fix (image): The image insertion pane should not be empty if opened by arrow down key press. Closes #12215.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 8, 2022
@CKEditorBot CKEditorBot added this to the iteration 57 milestone Sep 8, 2022
@mlewand mlewand mentioned this issue Sep 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmotyczynska mmotyczynska

Labels
domain:accessibility This issue reports an accessibility problem. package:image squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 57 (v35.2.0)
Development

Successfully merging a pull request may close this issue.

Fixes possibility to insert image url with keyboard ckeditor/ckeditor5
4 participants
@Reinmar @mlewand @CKEditorBot @mmotyczynska