New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the Paste from Office behaviour while using Text part language #12672
Comments
👍 |
1 similar comment
👍 |
We are consider stripping
We'll need to do a bit better research regarding the optimal aproach. |
tl;dr after a bit of a research., I think the main task here is just to remove the italics style on the text in other languages (Text part language plugin). To the points mentioned above, in our model's language attribute, we keep a pair in a form of: Taking it from the user's perspective:
To this, we add no. 4: Languages have italics style to distinguish them. I feel this is a wrong assumption. Not only do we style in italics but we also prevent removing italics which may result in bigger confusion and breaks a bit WYSIWYG idea. To refer to Word/Pages, those tools do language autodetection but don't distinguish them in the editor UI. In Word's case, you see language in the bottom toolbar, and Pages is not showing it to you at all. In the CKEditor case language distinction will be visible in the configured toolbar which is in my opinion enough. |
Let's remove the italics (style) and add to the docs information on how to style it by yourself. |
…extpartlanguage Other (language): TextPartLanguage doesn't style text as italic when language is set. Closes #12672. MINOR BREAKING CHANGE (language): Text with language set is no longer styled as italic. To re-enable previous behavior, add style .ck-content span[lang] { font-style: italic; } to your css.
📝 Provide detailed reproduction steps (if any)
✔️ Expected result
The content doesn't have an italic style.
❌ Actual result
The content has an italic style.
📃 Other details
MS Word wraps each text in
<span lang="">
so our Text part language feature kicks in, preserves the content and addsfont-style:italic
property.Translates to:
If you'd like to see this fixed sooner, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: