Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] Remove I type parameter from Collection #12763

Closed
Tracked by #12027
arkflpc opened this issue Oct 28, 2022 · 2 comments · Fixed by #12823
Closed
Tracked by #12027

[TS] Remove I type parameter from Collection #12763

arkflpc opened this issue Oct 28, 2022 · 2 comments · Fixed by #12823
Labels
domain:ts squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 61 (v37...

Comments

@arkflpc
Copy link
Contributor

arkflpc commented Oct 28, 2022 •
edited

Currently the Collection class has two generic parameters: T - item type and I - its id property name. It was inspired by community types. However, it seems redundant and overthought. I'd remove it.

Part of #12027.
@arkflpc arkflpc added the squad:core Issue to be handled by the Core team. label Oct 28, 2022
@Reinmar Reinmar added type:improvement This issue reports a possible enhancement of an existing feature. domain:ts labels Nov 2, 2022
@Reinmar
Copy link
Member

Reinmar commented Nov 2, 2022

Scope:

  • Remove the param from the class definition.
  • Review existing usage.
  • Review existing Collection documentation (API docs).

@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Nov 2, 2022
@arkflpc arkflpc mentioned this issue Nov 9, 2022
Merged
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. labels Nov 9, 2022
niegowski added a commit that referenced this issue Nov 9, 2022
@niegowski
Merge pull request #12823 from ckeditor/ck/12763-remove-i-from-collec…
4d82370 
…tion

Other (utils): Removed `I` generic parameter from `Collection`. Closes #12763.
@niegowski
Copy link
Contributor

Closed in #12823

@niegowski niegowski mentioned this issue Nov 9, 2022
Merged
@CKEditorBot CKEditorBot added this to the upcoming milestone Nov 9, 2022
arkflpc added a commit that referenced this issue Nov 14, 2022
@arkflpc
Merge pull request #12775 from ckeditor/ck/12709-typedoc-utils
b27b23f 
Internal (utils): Cleans up API doc in ckeditor5-utils. Closes #12709.

Other (utils): Removed I generic parameter from Collection. See #12763.
@Reinmar Reinmar modified the milestones: upcoming, iteration 61 Mar 10, 2023
@Witoso Witoso mentioned this issue Apr 4, 2023
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:ts squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 61 (v37.0.0)
Development

Successfully merging a pull request may close this issue.

Ck/12763 remove i from collection ckeditor/ckeditor5
4 participants
@Reinmar @niegowski @arkflpc @CKEditorBot