Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContextualBalloon conflict with the latest releases #1297

Closed
cedx opened this issue Oct 12, 2018 · 2 comments
Closed

ContextualBalloon conflict with the latest releases #1297

cedx opened this issue Oct 12, 2018 · 2 comments

Comments

@cedx
Copy link

cedx commented Oct 12, 2018

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

Classic Editor v11.0.1

📋 Steps to reproduce

  1. Create a custom build of the Classic Editor.
  2. Upgrade your dependencies to the latest versions available. See my package.json file : it shows what modules were updated and their current version.
  3. Compile the sources and open an instance of the editor in your browser.

✅ Expected result

Everything works as previously.

❎ Actual result

The editor does not work at all, and the browser console displays :

plugincollection-plugin-name-conflict: Two plugins with the same name were loaded.
  plugin1: function contextualballoon_ContextualBalloon()
​  plugin2: function balloon_contextualballoon_ContextualBalloon()
​  pluginName: "ContextualBalloon"

CKEditorError: "model-selection-set-ranges-not-range: Selection range set to an object that is not an instance of model.Range.

📃 Other details that might be useful

I did a clean install of Node.js modules (i.e. rm -rf node_modules && npm install : no change (the error is still there).
The custom editor uses the following plugins : source code

@Reinmar
Copy link
Member

Reinmar commented Oct 15, 2018

You've got an outdated table package in https://github.com/sab-international/rich-text-editor/blob/9fcf317ca724983edc74c04421477917edb8bcf8/package.json. It's trying to load an older version of ckeditor5-ui so ckeditor5-ui gets duplicated.

We're planning to implement a webpack plugin (or recommend existing one) which will warn about such situations

But for now, make sure to run a tool like npm-check to verify whether you're using the latest packages.

@cedx
Copy link
Author

cedx commented Oct 15, 2018

Thanks @Reinmar for pointing the source of this problem. Updating the image and table packages fixed the issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants