Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis & Node@19 & npm@9.2 stopped working #13076

Closed
pomek opened this issue Dec 15, 2022 · 2 comments
Closed

Travis & Node@19 & npm@9.2 stopped working #13076

pomek opened this issue Dec 15, 2022 · 2 comments
Assignees
Labels
squad:devops Issue to be handled by the Devops team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@pomek
Copy link
Member

pomek commented Dec 15, 2022

Provide a description of the task

https://app.travis-ci.com/github/ckeditor/ckeditor5/jobs/591276388

$ nvm install node
npm ERR! `spin` is not a valid npm option
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2022-12-15T10_48_14_808Z-debug-0.log
The command "npm config set spin false" failed and exited with 1 during .

I propose to use the latest LTS instead of any latest Node version.

ckeditor5/.travis.yml

Lines 15 to 16 in 23635bc

node_js:
- lts/*

@pomek pomek added type:task This issue reports a chore (non-production change) and other types of "todos". squad:devops Issue to be handled by the Devops team. labels Dec 15, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Dec 15, 2022
pomek added a commit to ckeditor/ckeditor5-linters-config that referenced this issue Dec 15, 2022
pomek added a commit to ckeditor/ckeditor5-angular that referenced this issue Dec 15, 2022
pomek added a commit to ckeditor/ckeditor5-inspector that referenced this issue Dec 15, 2022
pomek added a commit to ckeditor/ckeditor5-package-generator that referenced this issue Dec 15, 2022
pomek added a commit to ckeditor/ckeditor5-react that referenced this issue Dec 15, 2022
pomek added a commit to ckeditor/ckeditor5-vue2 that referenced this issue Dec 15, 2022
@pomek
Copy link
Member Author

pomek commented Dec 15, 2022

Done. See the reference commits above.

@pomek pomek closed this as completed Dec 15, 2022
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Dec 15, 2022
@pomek pomek added this to the iteration 60 milestone Dec 16, 2022
@psmyrek
Copy link
Contributor

psmyrek commented Feb 16, 2023

I noticed that CI (example run) started reporting the same error again:

npm ERR! `spin` is not a valid npm option
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2023-02-16T05_57_10_836Z-debug-0.log

$ node --version
v18.14.0

$ npm --version
9.3.1

$ nvm --version
0.39.3

It turns out that the minor bump of Node from v18.13.0 to v18.14.0 made a major bump of npm from 8.19.3 to 9.3.1.

Zrzut ekranu 2023-02-16 093801

Previously, npm was throwing an error that ended the CI run. Now, in version 9.3.1, npm probably doesn't throw an error anymore, so CI is not stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:devops Issue to be handled by the Devops team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

5 participants