Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] Make bodyCollectionContainer public #13928

Closed
Witoso opened this issue Apr 20, 2023 · 1 comment · Fixed by #14253
Closed

[TS] Make bodyCollectionContainer public #13928

Witoso opened this issue Apr 20, 2023 · 1 comment · Fixed by #14253
Assignees
@arkflpc
Labels
domain:ts package:ui squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 64 (v38...

Comments

@Witoso
Copy link
Member

Witoso commented Apr 20, 2023

Make bodyCollectionContainer public.

ckeditor5/packages/ckeditor5-ui/src/editorui/bodycollection.ts

Line 44 in fba274b

private _bodyCollectionContainer?: HTMLElement;

Rel: #9539

several use cases where developers need to access it:

  • to add a class there,
  • to move the entire container e.g. to the same parent w/ overflow: hidden that hosts the editing root so all the pieces of the UIs get cut in the same way,
  • to move the entire container to a different CSS context (e.g. to inherit styles), right now it's always straight in body > .

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@Witoso Witoso added type:improvement This issue reports a possible enhancement of an existing feature. package:ui squad:core Issue to be handled by the Core team. domain:ts labels Apr 20, 2023
@Witoso Witoso mentioned this issue Apr 20, 2023
Open
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Apr 26, 2023
@arkflpc
Copy link
Contributor

arkflpc commented May 25, 2023

Agreed with @oleq , that this property should be read-only.

@arkflpc arkflpc mentioned this issue May 25, 2023
Merged
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels May 25, 2023
niegowski added a commit that referenced this issue May 26, 2023
@niegowski
Merge pull request #14253 from ckeditor/ck/13928-make-bodyCollectionC…
1f5c8d0 
…ontainer-public

Feature (ui): `BodyCollection.bodyCollectionContainer` made public property. Closes #13928.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 26, 2023
@CKEditorBot CKEditorBot added this to the iteration 64 milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkflpc arkflpc

Labels
domain:ts package:ui squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 64 (v38.1.0)
Development

Successfully merging a pull request may close this issue.

BodyCollection.bodyCollectionContainer made public. ckeditor/ckeditor5
3 participants
@arkflpc @Witoso @CKEditorBot