Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to display PBC despite having license check #14235

Closed
mlewand opened this issue May 24, 2023 · 4 comments · Fixed by #14277
Closed

Ability to display PBC despite having license check #14235

mlewand opened this issue May 24, 2023 · 4 comments · Fixed by #14277
Assignees
@pszczesniak
Labels
intro Good first ticket. package:ui squad:features Issue to be handled by the Features team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 64 (v38...

Comments

@mlewand
Copy link
Contributor

mlewand commented May 24, 2023

📝 Provide a description of the new feature

We have some needs where we'd want to display PBC logo despite having a premium license in place (e.g. some of our demos).

If you'd like to see this feature implemented, add a 👍 reaction to this post.
@mlewand mlewand added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). intro Good first ticket. package:ui squad:features Issue to be handled by the Features team. labels May 24, 2023
@mlewand
Copy link
Contributor Author

mlewand commented May 24, 2023

Once that's done be sure to ping @usqr as he asked for this.

@Dumluregn
Copy link
Contributor

Let's remember about documentation and communication.

@mlewand
Copy link
Contributor Author

mlewand commented May 25, 2023 •
edited

Let's implement it as a new opt-in config option (in PBC namespace) to enforce PBC visibility. Let it be config.ui.poweredBy.forceVisible.

This way there's no breaking change at a cost of extra config prop. We're ok with that as PBC has its own namespace which is not crowded.

@ckeditor ckeditor deleted a comment from Dumluregn May 25, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label May 25, 2023
@pszczesniak pszczesniak self-assigned this May 29, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels May 29, 2023
@pszczesniak pszczesniak mentioned this issue May 30, 2023
Merged
oleq added a commit that referenced this issue May 30, 2023
@oleq
Merge pull request #14277 from ckeditor/ck/14235-ability-to-display-p…
b577283 
…bc-despite-having-license-check

Other (ui): Added a configuration option that forces the "Powered by" logo to show up despite a valid license key being used. Closes #14235.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 30, 2023
@oleq
Copy link
Member

oleq commented May 30, 2023

@usqr FYI you will be able to set config.ui.poweredBy.forceVisible: true. Currently only available in development code, available for the public in the upcoming release.

@CKEditorBot CKEditorBot added this to the iteration 64 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pszczesniak pszczesniak

Labels
intro Good first ticket. package:ui squad:features Issue to be handled by the Features team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 64 (v38.1.0)
Development

Successfully merging a pull request may close this issue.

"PoweredBy" config option thats allows to show it on demand. ckeditor/ckeditor5
5 participants
@oleq @mlewand @pszczesniak @Dumluregn @CKEditorBot