Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint – imports within a package must use relative imports #14329

Closed
pomek opened this issue Jun 5, 2023 · 0 comments · Fixed by ckeditor/ckeditor5-linters-config#21
Closed

ESLint – imports within a package must use relative imports #14329

pomek opened this issue Jun 5, 2023 · 0 comments · Fixed by ckeditor/ckeditor5-linters-config#21
Assignees
@psmyrek
Labels
squad:devops Issue to be handled by the Devops team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 64 (v38...

Comments

@pomek
Copy link
Member

pomek commented Jun 5, 2023 •
edited

Provide a description of the task

To avoid the code duplication when preparing DLL files from the release/ directory, all imports within a package must use relative paths. Otherwise, Node/webpack looks for files from node_modules when using scoped imports.

Scope

  • As above.
  • Fix the CKEditor 5 code base.
@pomek pomek added type:task This issue reports a chore (non-production change) and other types of "todos". squad:devops Issue to be handled by the Devops team. package:dev and removed package:dev labels Jun 5, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jun 5, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Jun 5, 2023
This was referenced Jun 7, 2023
Merged
Merged
@michalbilik michalbilik mentioned this issue Jun 12, 2023
Merged
psmyrek added a commit to ckeditor/ckeditor5-linters-config that referenced this issue Jun 19, 2023
@psmyrek
Merge pull request #21 from ckeditor/ck/14329
af2205c 
Feature (eslint-plugin-ckeditor5-rules): Created the `ckeditor5-rules/no-scoped-imports-within-package` that disallows using scoped import (like `"@ckeditor/ckeditor5-*"`) to the same package where the import declaration is located. Closes ckeditor/ckeditor5#14329.

Other (eslint-config-ckeditor5): Enabled the `ckeditor5-rules/no-scoped-imports-within-package` in the ESLint configuration.

Internal (eslint-config-ckeditor5): Bumped ESLint parser configuration to target the ES2020 grammar.

Internal (eslint-plugin-ckeditor5-rules): Aligned all tests for all ESLint rules to target the ES2020 grammar.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jun 19, 2023
@CKEditorBot CKEditorBot added this to the iteration 64 milestone Jun 19, 2023
psmyrek added a commit that referenced this issue Jun 19, 2023
@psmyrek
Merge pull request #14358 from ckeditor/ck/14329
b6d7cd9 
Docs: Added documentation for `no-scoped-imports-within-package` ESLint rule. See #14329.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psmyrek psmyrek

Labels
squad:devops Issue to be handled by the Devops team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 64 (v38.1.0)
3 participants
@pomek @CKEditorBot @psmyrek