Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font color and Font background color throw error while having buttons in the main toolbar and the balloon toolbar #15580

Closed
Mgsy opened this issue Dec 21, 2023 · 0 comments · Fixed by #15658
Closed

Font color and Font background color throw error while having buttons in the main toolbar and the balloon toolbar #15580

Mgsy opened this issue Dec 21, 2023 · 0 comments · Fixed by #15658
Assignees
@illia-stv
Labels
squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 71 (v41...

Comments

@Mgsy
Copy link
Member

Mgsy commented Dec 21, 2023 •
edited

📝 Provide detailed reproduction steps (if any)

  1. Create a classic editor with the Balloon toolbar plugin.
  2. Load Font color and Font background color plugins.
  3. Add fontColor and fontBackgroundColor buttons to the main toolbar and the balloon toolbar configuration.
  4. Run the editor and select some text.
  5. Click on the font color or font background color buttons within the balloon toolbar.

✔️ Expected result

There is no error in the console.

❌ Actual result

The error is thrown.

ckeditorerror.js:90 Uncaught TypeError: Cannot set properties of undefined (setting 'selectedColor')
    at Dm.updateSelectedColors (colorgridsfragmentview.js:104:26)
    at Mm.updateSelectedColors (colorselectorview.js:226:37)
    at ss.<anonymous> (colorui.js:121:44)
    at ss.fire (emittermixin.js:146:47)
    at ss.set [as isOpen] (observablemixin.js:72:30)
    at cs.<anonymous> (dropdownview.js:120:18)
    at cs.fire (emittermixin.js:146:47)
    at O (emittermixin.js:425:17)
    at cs.fire (emittermixin.js:165:25)
    at Ui.<anonymous> (buttonview.js:105:30)

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Mgsy Mgsy added type:bug This issue reports a buggy (incorrect) behavior. support:2 An issue reported by a commercially licensed client. squad:core Issue to be handled by the Core team. labels Dec 21, 2023
@illia-stv illia-stv self-assigned this Jan 8, 2024
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 8, 2024
@illia-stv illia-stv mentioned this issue Jan 8, 2024
Merged
niegowski added a commit that referenced this issue Jan 19, 2024
@niegowski
Merge pull request #15658 from ckeditor/ck/15580-font-color-and-font-…
63aaa3e 
…background-color-throw-error

Fix (font): Font color and font background should work in both the main toolbar and the balloon toolbar. Closes #15580.

MINOR BREAKING CHANGE (font): The `colorSelectorView` property will no longer be accessible from the `ColorUI` plugin in the `@ckeditor/ckeditor5-font/src/ui/colorui.ts`.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 19, 2024
@CKEditorBot CKEditorBot added this to the iteration 71 milestone Jan 19, 2024
@CKEditorBot CKEditorBot mentioned this issue Jan 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@illia-stv illia-stv

Labels
squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 71 (v41.1.0)
3 participants
@Mgsy @CKEditorBot @illia-stv