CKBox plugin order matters, and it shouldn't

[Witoso]

📝 Provide detailed reproduction steps (if any)

1. Add the CKBox plugin before the  ImageBlock and ImageInline plugins.
2. Change image from inline to block (or reverse)

✔️ Expected result

The ckboxImageId attribute stays.

❌ Actual result

The ckboxImageId is dropped.

❓ Possible solution

Discovered in docs. The reason for this is that in the build-classic.js snippet we add CKBox before the Image:

ckeditor5/docs/_snippets/build-classic.js

Lines 41 to 45 in 0e28a3f

	CKBox,
	CloudServices,
	EasyImage,
	Heading,
	Image,

Because of that, when schema in CKBox is being registered, the ImageBlock and ImageInline are not loaded yet. That's why in the code below the attribute ckboxImageId is not registered for images.

ckeditor5/packages/ckeditor5-ckbox/src/ckboxediting.ts

Lines 122 to 128 in 0e28a3f

	if ( schema.isRegistered( 'imageBlock' ) ) {
	schema.extend( 'imageBlock', { allowAttributes: [ 'ckboxImageId', 'ckboxLinkId' ] } );
	}
	if ( schema.isRegistered( 'imageInline' ) ) {
	schema.extend( 'imageInline', { allowAttributes: [ 'ckboxImageId', 'ckboxLinkId' ] } );
	}

There is a similar problem with usage CKBox and BlockToolbar, the order influenced loading. Discussed internally:

Why CKBoxUI registers the ckbox button in the component factory upon afterInit()? There is no comment. There are no tests that verify that. What was the reason? (it causes problems with plugin initialisation and block toolbar)

(...) I believe, we used afterInit() due to

// Do not register the `ckbox` button if the command does not exist. if ( !editor.commands.get( 'ckbox' ) ) { return; }

What if there was a helper like
 

function canCKBoxWork() {
    const hasConfiguration = !!editor.config.get( 'ckbox' );
    const isLibraryLoaded = !!window.CKBox;
    return hasConfiguration && isLibraryLoaded
}

and both editing and UI used it on init?

But this

📃 Other details

• Browser: …
• OS: …
• First affected CKEditor version: …
• Installed CKEditor plugins: …

---

If you'd like to see this fixed sooner, add a 👍 reaction to this post.