Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New installation methods] Allow passing a translations object in the configuration #15713

Closed
arkflpc opened this issue Jan 17, 2024 · 0 comments · Fixed by #15792
Closed

[New installation methods] Allow passing a translations object in the configuration #15713

arkflpc opened this issue Jan 17, 2024 · 0 comments · Fixed by #15792
Assignees
@illia-stv
Labels
squad:core Issue to be handled by the Core team.
Milestone
iteration 72 (v41...

Comments

@arkflpc
Copy link
Contributor

arkflpc commented Jan 17, 2024 •
edited by filipsobol

The scope of this task is to add a new translations configuration object that has priority over the CKEDITOR_TRANSLATIONS object that the current translations register. See the RFC for new installation methods for usage examples.

The translations object should accept the object (translations: {}) or an array of objects to be merged internally (translations: [ {}, {} ]).

We've already created a working PoC that can be used, but it requires writing tests and a proper review process.
@arkflpc arkflpc added the squad:core Issue to be handled by the Core team. label Jan 17, 2024
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jan 17, 2024
@illia-stv illia-stv self-assigned this Jan 17, 2024
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Jan 17, 2024
@filipsobol filipsobol changed the title [New installation methods] Integrate Rollup translation plugin into CKEditor5 [New installation methods] Allow passing a `translations' object in the configuration Jan 18, 2024
@filipsobol filipsobol changed the title [New installation methods] Allow passing a `translations' object in the configuration [New installation methods] Allow passing a translations object in the configuration Jan 18, 2024
@filipsobol filipsobol mentioned this issue Jan 18, 2024
Closed
21 tasks
@illia-stv illia-stv mentioned this issue Jan 22, 2024
Closed
@filipsobol filipsobol linked a pull request Jan 25, 2024 that will close this issue
Allow passing a 'translations' object in the configuration #15734
Closed
@illia-stv illia-stv mentioned this issue Feb 2, 2024
Merged
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Feb 5, 2024
@CKEditorBot CKEditorBot added this to the iteration 72 milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@illia-stv illia-stv

Labels
squad:core Issue to be handled by the Core team.
Projects
None yet
Milestone
iteration 72 (v41.2.0)
3 participants
@arkflpc @CKEditorBot @illia-stv