Allow passing a 'translations' object in the configuration #15734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkflpc
requested changes
Jan 23, 2024
filipsobol
requested changes
Jan 25, 2024
pszczesniak
requested changes
Jan 26, 2024
filipsobol
requested changes
Jan 26, 2024
filipsobol
reviewed
Jan 30, 2024
filipsobol
approved these changes
Jan 30, 2024
pszczesniak
requested changes
Feb 1, 2024
pszczesniak
approved these changes
Feb 1, 2024
niegowski
requested changes
Feb 1, 2024
Comment on lines
+281
to
+284
| /** | ||
| * We don't pass translations to the config, because its behavior of splitting keys | ||
| * with dots (e.g. `resize.width` => `resize: { width }`) breaks the translations. | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /** | |
| * We don't pass translations to the config, because its behavior of splitting keys | |
| * with dots (e.g. `resize.width` => `resize: { width }`) breaks the translations. | |
| */ | |
| // We don't pass translations to the config, because its behavior of splitting keys | |
| // with dots (e.g. `resize.width` => `resize: { width }`) breaks the translations. |
illia-stv
force-pushed
the
ck/15713-allow-passing-a-translations-object-in-the-configuration
branch
from
ad85fdf
to
2ba169b
Compare
Experimental handling of style and class attribute conversion. Added tests ensuring proper consumables are consumed for style and class attributes. Added tests proper downcast of style and class attributes. Docs: Fix media embed preview demo.
Fix license header. Remove redundant testColor from toolbar in test.
Register custom element on the editor side. TokenIgnores configuration extended to ignore CKEditor package names. Internal: Vale evaluation. [skip ci] Docs: update TS version requirement. [short flow] Docs: TS info. [short flow] Add new rule to enforce correct imports of the SVG icons (#15705) Internal: Add new ESLint rule to enforce correct imports of the SVG icons. Closes #15704. Docs: add additional info about the source code of the drag-drop demo. Closes #15722 Update packages/ckeditor5-clipboard/docs/features/drag-drop.md Narrow down the condition to check whether to use the AutoLink plugin. AutoLink shoudl work on paste not on drag method. Remove comment. Improved the Features index page using Vale. Docs: rewording. [short flow] Fix(ui): List view item deregistration. Fix(ui): List view item deregistration. Test: List separator view registration FocusCycler docs update. Docs: updating autosave install. Docs: updating the keyboards shortcuts table. Fix and tests. Docs: adding release dates to releases. Internal: Vale evaluation. [skip ci] Other (source-editing): Source editing will now throw when used with real-time collaboration. Added `sourceEditing.allowCollaborationFeatures` configuration flag that suppresses the error and allows to use both features together. Fixed leaked DOM element in test. Used better types. Fixed code formatting. Other: Updated translations. [skip ci] Move translate type to utils. Revert "Merge branch 'master' into ck/15713-allow-passing-a-translations-object-in-the-configuration" This reverts commit 0c7c1ee, reversing changes made to 0cfc719. Code review fixes.
illia-stv
force-pushed
the
ck/15713-allow-passing-a-translations-object-in-the-configuration
branch
from
2ba169b
to
57d2c2f
Compare
|
Due reverts in history we decided move PR to new one here: #15792 |
arkflpc
deleted the
ck/15713-allow-passing-a-translations-object-in-the-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (core,utils): Should use translations which passed in config. Closes #15713.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.