Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export a few more types/classes from the mention package #16044

Closed
Cyperghost opened this issue Mar 15, 2024 · 2 comments · Fixed by #16068
Closed

Export a few more types/classes from the mention package #16044

Cyperghost opened this issue Mar 15, 2024 · 2 comments · Fixed by #16068
Labels
domain:dx This issue reports a developer experience problem or possible improvement. domain:framework-dx This issue reports a problem with the developer experience while working with the framework. package:mention type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Cyperghost
Copy link

📝 Provide a description of the new feature

There are currently no exports for a few types and classes that can be used in other auto-completion features similar to the mention auto-completion.
These types/classes are interesting

MentionsView from "@ckeditor/ckeditor5-mention/src/ui/mentionsview";
MentionFeedObjectItem from "@ckeditor/ckeditor5-mention/src/mentionconfig";
MentionListItemView from "@ckeditor/ckeditor5-mention/src/ui/mentionlistitemview";
DomWrapperView from "@ckeditor/ckeditor5-mention/src/ui/domwrapperview";

What is the expected behavior of the proposed feature?
We would use this to create our own auto-completion for others, then mention, but not completely rewrite everything.


If you'd like to see this feature implemented, add a 👍 reaction to this post.

@Cyperghost Cyperghost added the type:feature This issue reports a feature request (an idea for a new functionality or a missing option). label Mar 15, 2024
@Witoso Witoso added package:mention type:improvement This issue reports a possible enhancement of an existing feature. domain:dx This issue reports a developer experience problem or possible improvement. domain:framework-dx This issue reports a problem with the developer experience while working with the framework. and removed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). labels Mar 19, 2024
@Witoso
Copy link
Member

Witoso commented Mar 19, 2024

Thanks for the request! @arkflpc @filipsobol , I'm not sure if we need to investigate this further, or just add it?

@filipsobol
Copy link
Member

I'm not too familiar with this feature, so I can't make the final call, but in general I see no reason why we shouldn't do this.

illia-stv added a commit that referenced this issue Mar 22, 2024
…pes-or-classes-from-the-mention-package

Other (mention): Export MentionsView, MentionListItemView, DomWrapperView classes and MentionFeedObjectItem type. Closes #16044.
@CKEditorBot CKEditorBot added this to the iteration 73 milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:dx This issue reports a developer experience problem or possible improvement. domain:framework-dx This issue reports a problem with the developer experience while working with the framework. package:mention type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants