Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's impossible to undo creating a list item while retaining the list marker when there is already some content in the editable #16240

Closed
mabryl opened this issue Apr 18, 2024 · 0 comments · Fixed by #16293
Labels
package:autoformat squad:core Issue to be handled by the Core team. support:1 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@mabryl
Copy link
Contributor

mabryl commented Apr 18, 2024

📝 Provide detailed reproduction steps (if any)

  1. Type anything into the editor (or create an empty paragraph) and create a new line
  2. Type 1. or * and hit Space to insert a list item via block autoformatting
  3. Press backspace

✔️ Expected result

The creation of the list should be undone but the marker used to create it should remain in the editable. This is the case when the newly created list item is the only piece of content:

Screen.Recording.2024-04-18.at.09.57.52.mov

❌ Actual result

When content is already present in the editable, deleting the list item will also remove the marker:

Screen.Recording.2024-04-18.at.10.00.14.mov

❓ Possible solution

This report comes from a customer. You can find their insight into the cause of the issue in the linked ticket.

📃 Other details

  • Browser: cross-browser
  • OS: cross-OS
  • First affected CKEditor version: N/A
  • Installed CKEditor plugins: Autoformat

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@mabryl mabryl added type:bug This issue reports a buggy (incorrect) behavior. package:autoformat support:2 An issue reported by a commercially licensed client. squad:core Issue to be handled by the Core team. labels Apr 18, 2024
@aldonace-wu aldonace-wu added support:1 An issue reported by a commercially licensed client. and removed support:2 An issue reported by a commercially licensed client. labels Apr 18, 2024
niegowski added a commit that referenced this issue Apr 30, 2024
Fix (autoformat): Pressing the backspace after autoformat should retain the typed content after undoing the block format change. Closes #16240.

Internal (typing): Fixed the target range size verification for backspace handling. See #16240.
@CKEditorBot CKEditorBot added this to the iteration 74 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:autoformat squad:core Issue to be handled by the Core team. support:1 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants