Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce continous integration for CKEditor 5 packages #354

Closed
Reinmar opened this issue Nov 7, 2016 · 20 comments
Closed

Introduce continous integration for CKEditor 5 packages #354

Reinmar opened this issue Nov 7, 2016 · 20 comments
Assignees
Labels
type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Nov 7, 2016

Implements: ckeditor/ckeditor5-design#45.

CKEditor 5 needs CI, it's pretty obvious. Especially, taken CKEditor's multi-repo architecture this is unavoidable.

We haven't tracked our initial research, but we decided to go with Travis. Initially, we'll only run tests in Chrome on CI. In the future, we can think about adding more browsers, using e.g. BrowserStack.

@Reinmar Reinmar added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). status:confirmed labels Nov 7, 2016
@Reinmar Reinmar added this to the iteration 5 milestone Nov 7, 2016
@Reinmar
Copy link
Member Author

Reinmar commented Nov 7, 2016

We've got first CIs up and running: https://travis-ci.org/ckeditor :). We should be able to add CIs for all remaining CKEditor 5 packages today.

@Reinmar
Copy link
Member Author

Reinmar commented Nov 7, 2016

Possible improvements:

@Reinmar
Copy link
Member Author

Reinmar commented Nov 7, 2016

In the future, we can think about adding more browsers, using e.g. BrowserStack.

There's a risk that once we implement more browser related quirks we'll also need to work on combining code coverage results. Currently, we're happy with our 100% and we wouldn't like this to be gone.

@Reinmar
Copy link
Member Author

Reinmar commented Nov 7, 2016

One more thing is missing now – linter check.

@Reinmar
Copy link
Member Author

Reinmar commented Nov 7, 2016

And another thing – the build badge should in my opinion show the master branch status. Otherwise, every failed PR will affect the build status visible in the README.

So e.g. in the list package we should be using: https://travis-ci.org/ckeditor/ckeditor5-list.svg?branch=master

@Reinmar
Copy link
Member Author

Reinmar commented Nov 7, 2016

And to keep in mind – pushing code coverage reports to CodeClimate for non ckeditor5-dev-* packages doesn't work for some reason.

@Reinmar
Copy link
Member Author

Reinmar commented Nov 7, 2016

Another thing – in each PR two things are changed:

image

Sometimes, I've got one of these checks failed and I can see that a pretty odd commit is then checked.

First of all – do I understand correctly that Travis checks if the code in the actual commit is ok (first check) and that merging this PR won't break the master (second check)?

Second – why did it fail in here: ckeditor/ckeditor5-utils#98? The failed tests are weird cause it seems that the tests were taken from the master and the source from the branch... or something. Needs to be verified.

@pomek
Copy link
Member

pomek commented Nov 8, 2016

And another thing – the build badge should in my opinion show the master branch status. Otherwise, every failed PR will affect the build status visible in the README.

Fixed. In each package we will show build status from master.

@pomek
Copy link
Member

pomek commented Nov 8, 2016

And to keep in mind – pushing code coverage reports to CodeClimate for non ckeditor5-dev-* packages doesn't work for some reason.

Reported - https://github.com/ckeditor/ckeditor5-dev-tests/issues/16

@pomek
Copy link
Member

pomek commented Nov 8, 2016

run tests with source maps – it's currently very hard to tell where a test fails based on the stack trace that you get on CI.

Worth checking - litixsoft/karma-mocha-reporter#81

@Reinmar
Copy link
Member Author

Reinmar commented Nov 8, 2016

Fixed. In each package we will show build status from master.

Not yet. You forgot about the dev-* packages.

@pomek
Copy link
Member

pomek commented Nov 9, 2016

Not yet. You forgot about the dev-* packages.

Done.

@Reinmar
Copy link
Member Author

Reinmar commented Nov 14, 2016

Another thing – update the gulp create-package task.

@pomek
Copy link
Member

pomek commented Nov 15, 2016

@Reinmar
Copy link
Member Author

Reinmar commented Nov 15, 2016

Let's sum up what remained to be done:

@pomek
Copy link
Member

pomek commented Nov 15, 2016

CI for ckeditor5 package which will allow testing setup of branches.

#356

@pomek
Copy link
Member

pomek commented Nov 16, 2016

Move manual tests out of Bender.

https://github.com/ckeditor/ckeditor5-dev-tests/issues/27

@Reinmar
Copy link
Member Author

Reinmar commented Nov 24, 2016

Check tests in Safari and Firefox 51+ (https://developer.mozilla.org/en-US/Firefox/Releases/51 – cause it brings finally the full support for for-of loops).

I've run tests in Safari and Firefox 51 and 2-4 fail on each of these browsers, so we're doing great :).

Reinmar added a commit to ckeditor/ckeditor5-autoformat that referenced this issue Nov 28, 2016
Reinmar added a commit to ckeditor/ckeditor5-basic-styles that referenced this issue Nov 28, 2016
Reinmar added a commit to ckeditor/ckeditor5-clipboard that referenced this issue Nov 28, 2016
Reinmar added a commit to ckeditor/ckeditor5-core that referenced this issue Nov 28, 2016
Reinmar added a commit to ckeditor/ckeditor5-editor-classic that referenced this issue Nov 28, 2016
Reinmar added a commit to ckeditor/ckeditor5-engine that referenced this issue Nov 28, 2016
Reinmar added a commit to ckeditor/ckeditor5-enter that referenced this issue Nov 28, 2016
Reinmar added a commit to ckeditor/ckeditor5-heading that referenced this issue Nov 28, 2016
Reinmar added a commit to ckeditor/ckeditor5-image that referenced this issue Nov 28, 2016
Reinmar added a commit to ckeditor/ckeditor5-link that referenced this issue Nov 28, 2016
Reinmar added a commit to ckeditor/ckeditor5-list that referenced this issue Nov 28, 2016
Reinmar added a commit to ckeditor/ckeditor5-markdown-gfm that referenced this issue Nov 28, 2016
Reinmar added a commit to ckeditor/ckeditor5-paragraph that referenced this issue Nov 28, 2016
Reinmar added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Nov 28, 2016
Reinmar added a commit to ckeditor/ckeditor5-typing that referenced this issue Nov 28, 2016
Reinmar added a commit to ckeditor/ckeditor5-ui-default that referenced this issue Nov 28, 2016
Reinmar added a commit to ckeditor/ckeditor5-undo that referenced this issue Nov 28, 2016
Reinmar added a commit to ckeditor/ckeditor5-utils that referenced this issue Nov 28, 2016
@Reinmar
Copy link
Member Author

Reinmar commented Nov 28, 2016

I removed the code climate badge in all repos.

@Reinmar
Copy link
Member Author

Reinmar commented Nov 28, 2016

I consider this finished. I reported missing followups.

@Reinmar Reinmar closed this as completed Nov 28, 2016
bendemboski pushed a commit to PatentNavigation/ckeditor5-typing-v19 that referenced this issue Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

2 participants