-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce continous integration for CKEditor 5 packages #354
Comments
We've got first CIs up and running: https://travis-ci.org/ckeditor :). We should be able to add CIs for all remaining CKEditor 5 packages today. |
Possible improvements:
|
There's a risk that once we implement more browser related quirks we'll also need to work on combining code coverage results. Currently, we're happy with our 100% and we wouldn't like this to be gone. |
One more thing is missing now – linter check. |
And another thing – the build badge should in my opinion show the master branch status. Otherwise, every failed PR will affect the build status visible in the README. So e.g. in the list package we should be using: https://travis-ci.org/ckeditor/ckeditor5-list.svg?branch=master |
And to keep in mind – pushing code coverage reports to CodeClimate for non ckeditor5-dev-* packages doesn't work for some reason. |
Another thing – in each PR two things are changed: Sometimes, I've got one of these checks failed and I can see that a pretty odd commit is then checked. First of all – do I understand correctly that Travis checks if the code in the actual commit is ok (first check) and that merging this PR won't break the master (second check)? Second – why did it fail in here: ckeditor/ckeditor5-utils#98? The failed tests are weird cause it seems that the tests were taken from the master and the source from the branch... or something. Needs to be verified. |
Fixed. In each package we will show build status from |
Reported - https://github.com/ckeditor/ckeditor5-dev-tests/issues/16 |
Worth checking - litixsoft/karma-mocha-reporter#81 |
Not yet. You forgot about the dev-* packages. |
Done. |
Another thing – update the |
Let's sum up what remained to be done:
|
|
|
I've run tests in Safari and Firefox 51 and 2-4 fail on each of these browsers, so we're doing great :). |
I removed the code climate badge in all repos. |
I consider this finished. I reported missing followups. |
Implements: ckeditor/ckeditor5-design#45.
CKEditor 5 needs CI, it's pretty obvious. Especially, taken CKEditor's multi-repo architecture this is unavoidable.
We haven't tracked our initial research, but we decided to go with Travis. Initially, we'll only run tests in Chrome on CI. In the future, we can think about adding more browsers, using e.g. BrowserStack.
The text was updated successfully, but these errors were encountered: