Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataController#extendSelection should not move selection to the inside of an object #3904

Closed
szymonkups opened this issue Nov 30, 2016 · 0 comments · Fixed by ckeditor/ckeditor5-engine#709
Assignees
Milestone

Comments

@szymonkups
Copy link
Contributor

Extracted from #3893 @Reinmar's comment:

General rule of thumb – selection should not be moved to the inside of an object. E.g.:

<obj></obj><p>^x</p> + backspace => the selection must not be moved to <obj>^</obj>

This means that extending the selection to the left in the case mentioned above should not put the focus inside the object. The focus must be placed before the object.

  • <obj></obj><p>^x</p> + extend left -> [<obj></obj><p>]x</p>,
  • <obj></obj>[<obj></obj>] + extend left -> [<obj></obj><obj></obj>],

So in other words, the selection outputed from the extendSelection should not cross object boundaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants