This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Added objects handling to modifySelection method #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinmar
reviewed
Dec 1, 2016
| document.schema.registerItem( 'p', '$block' ); | ||
| document.schema.registerItem( 'x', '$block' ); | ||
| document.schema.registerItem( 'img', '$inline' ); | ||
| document.schema.registerItem( 'b', '$inline' ); |
There was a problem hiding this comment.
This is confusing. We don't have inline containers in the model. <b> should rather be an attribute. This test:
<p>foo<b>[]</b><inlineObj>bar</inlineObj></p>have no sense. In the paragraph you can either have text or inline objects.
There was a problem hiding this comment.
BTW. It's better to have many schema definitions – one per some describe() block. It's then easier to remember all setting for each block. E.g. you can move the additional setting to the newly added describe() (and keep the rest here for all tests).
Reinmar
reviewed
Dec 1, 2016
| describe( 'objects handling', () => { | ||
| test( | ||
| 'extends over next object element when at the end of an element', | ||
| '<p>foo[]</p><obj>bar</obj>', |
There was a problem hiding this comment.
I miss a test case for <blockquote><p>foo[]</p></blockquote><obj></obj>.
There was a problem hiding this comment.
This looks like a bigger case and it will be handled separately.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ckeditor/ckeditor5#3904.