Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrap should not be exporte from dowcast helper #4453

Closed
pjasiun opened this issue Dec 21, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1625
Closed

wrap should not be exporte from dowcast helper #4453

pjasiun opened this issue Dec 21, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1625
Assignees
@jodator
Labels
package:engine
Milestone
iteration 22

Comments

@pjasiun
Copy link

pjasiun commented Dec 21, 2018

Follow-up of: ckeditor/ckeditor5-engine#1613 (comment).

The wrap function is now the only function which is exported and should not be. It should also have no direct test, but only integrational tests.

See also: https://github.com/ckeditor/ckeditor5-engine/issues/1306#issuecomment-378870980
pjasiun referenced this issue in ckeditor/ckeditor5-engine Jan 2, 2019
Merge pull request #1625 from ckeditor/t/1616
1c7ef68 
Other: Remove wrap from public API. Closes #1616.

BREAKING CHANGE: The wrap() conversion helper was removed from public API.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 22 milestone Oct 9, 2019
This was referenced Oct 11, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:engine
Projects
None yet
Milestone
iteration 22
Development

Successfully merging a pull request may close this issue.

T/1616: Hide wrap from public API ckeditor/ckeditor5-engine
3 participants
@jodator @pjasiun @mlewand