This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/1619: Expose protectely insertElement and createUIElement conversion helpers #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjasiun
reviewed
Jan 2, 2019
| * | ||
| * This converter binds created UI elements with the marker name using {@link module:engine/conversion/mapper~Mapper#bindElementToMarker}. | ||
| * | ||
| * @param {module:engine/view/uielement~UIElement|Function} elementCreator A view UI element or a function returning the view element |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Expose
insertElement()andcreateUIElement()conversion helpers as protected functions. Closes ckeditor/ckeditor5#4456.Additional information
getData()fromdev-utils/model.jsused in testswrap()method removal from public API. It will need to stay as export but will be tested only by integration tests (wrapshould not be exporte from dowcast helper ckeditor5#4453). Thewrap()method is used by attribute change "catch-all" converter indev-utils#getData()