Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack destroy() and restart() calls when the editor isn't initialized #4696

Closed
ma2ciek opened this issue Jun 26, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-watchdog#33
Closed

Stack destroy() and restart() calls when the editor isn't initialized #4696

ma2ciek opened this issue Jun 26, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-watchdog#33
Labels
package:watchdog type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 29 (v17...

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Jun 26, 2019

A follow-up to #4692.

The following code will throw an error:

watchdog.create( element, config );

// Immediately called (until the editor is fully initialized):
watchdog.destory();

The fix should be pretty easy.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-watchdog Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:watchdog labels Oct 9, 2019
@ma2ciek ma2ciek mentioned this issue Jan 17, 2020
Closed
@ma2ciek
Copy link
Contributor Author

ma2ciek commented Jan 31, 2020

It's done in the ContextWatchdog feature, which will be used in the integrations. And I think that we currently don't need it in the EditorWatchdog.

@ma2ciek ma2ciek mentioned this issue Jan 31, 2020
Merged
6 tasks
scofalik added a commit to ckeditor/ckeditor5-watchdog that referenced this issue Feb 10, 2020
@scofalik
Merge pull request #33 from ckeditor/i/6079
76c4938 
Feature: Introduced `ContextWatchdog` which is a watchdog for `Context`. Closes ckeditor/ckeditor5#6079. Closes ckeditor/ckeditor5#6042. Closes ckeditor/ckeditor5#4696.

BREAKING CHANGE: The `Watchdog` class was renamed to `EditorWatchdog` and is available in `src/editorwatchdog.js`.
BREAKING CHANGE: The `EditorWatchdog.for()` method was removed in favor of the constructor.
BREAKING CHANGE: The `EditorWatchdog#constructor()` API changed, now the `EditorWatchdog` accepts the editor class as the first argument and the watchdog configuration as the second argument. The `EditorWatchdog` editor creator now defaults to `( sourceElementOrData, config ) => Editor.create( sourceElementOrData, config )`.
@Reinmar Reinmar modified the milestones: backlog, iteration 29 Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:watchdog type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 29 (v17.0.0)
Development

Successfully merging a pull request may close this issue.

[WIP] Introduce the ContextWatchdog ckeditor/ckeditor5-watchdog
3 participants
@Reinmar @ma2ciek @mlewand