Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove config.image.defaultToolbar #5070

Closed
Reinmar opened this issue Feb 24, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-image#103
Closed

Remove config.image.defaultToolbar #5070

Reinmar opened this issue Feb 24, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-image#103
Assignees
@oleq
Labels
package:image type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 10

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 24, 2017

As explained in https://github.com/ckeditor/ckeditor5-ui/issues/155#issuecomment-282300881.

For now, we're going to require that you specify the config. We'll create a system to pre-configure this by features in the future (see #409).
@Reinmar Reinmar assigned Reinmar and unassigned Reinmar Feb 24, 2017
@Reinmar
Copy link
Member Author

Reinmar commented Feb 28, 2017

https://github.com/ckeditor/ckeditor5-image/issues/64#issuecomment-283079934

Let's not forget that the in all our samples and everywhere the toolbar should be configured as styles | alt.

Reinmar referenced this issue in CKEditor5/ckeditor5.github.io Apr 20, 2017
@Reinmar
Aligned image toolbar buttons order to https://github.com/ckeditor/ck…
ff4ffcf 
…editor5-image/issues/60.
Reinmar referenced this issue in ckeditor/ckeditor5-build-classic Apr 20, 2017
@Reinmar
Other: Changed the order of buttons in the image toolbar. See https:/…
131cbe7 
…/github.com/ckeditor/ckeditor5-image/issues/60.
@Reinmar
Copy link
Member Author

Reinmar commented Apr 20, 2017

Related thread: https://github.com/ckeditor/ckeditor5-ui/issues/154#issuecomment-282342455.

@Reinmar
Copy link
Member Author

Reinmar commented Apr 20, 2017

I changed the order of buttons in the classic build (ckeditor/ckeditor5-build-classic@131cbe7) and on https://ckeditor5.github.io (CKEditor5/ckeditor5.github.io@ff4ffcf). What remains here is getting rid of defaultToolbar setting.

@oleq oleq self-assigned this Apr 24, 2017
oleq referenced this issue in ckeditor/ckeditor5-image Apr 24, 2017
@oleq
Other: Removed config.image.defaultToolbar. Closes #60.
28a365f
Reinmar referenced this issue in ckeditor/ckeditor5-image Apr 24, 2017
@Reinmar
Merge pull request #103 from ckeditor/t/60
4db7b34 
Other: Removed automatically filled `config.image.defaultToolbar`. Now, when initializing editor one must always define `config.image.toolbar`. Closes #60.

BREAKING CHANGE: The `config.image.defaultToolbar` is no longer available. All editor instances must configure `config.image.toolbar` instead.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 10 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:image labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:image type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 10
Development

Successfully merging a pull request may close this issue.

t/60: Removed config.image.defaultToolbar ckeditor/ckeditor5-image
3 participants
@Reinmar @oleq @mlewand